M4.1 - 8.8.3 2024112800 | Codingerror completion\custum_completion

[gemguardian]

Describe the bug
After updating to 8.8.3 2024112800 on our Moodle 4.1 we see the error below

Versions uses
Moodle version: 4.1
Boooking version: 8.8.3

To Reproduce
We have this error after updating in one of our courses.

Expected behavior
Viewing the bookingsmodule

Screenshots

Additional context
After update. We think it's caused by #629

[semteacher]

@gemguardian Hello. Do you know what set of completion conditions were set for that particular activity?
Only 1 custom completion setting has been supported in the latest veriosn of Booking:

[gemguardian]

@semteacher Not by hearth - and I cannot see it anymore due to the error.
I need to dive into the database for this.

THis is what the table shows:

To be honest - I think it is really strange that you simply take out completion sets like this. this could cause so many issues for so many sites. or at least build something in that transfer the previous set completion back to none.

[gemguardian]

@semteacher okay when I change the completion setting to 1 - the activity is backup again.

When i try to set it like they want to - it 'bugs' out again

so basically what it 'boiles' down to that I still see the options "grade necesaary" and that's been used.

Which is NOT a custom requirment but a default requirement from Moodle.

The screenshot you send me is from a Moodle 4.4 or 4.5 - which has a different interface (this has been changed)

As I wrote down we work with Moodle 4.1 so it makes sense we see the 'grade' crtieria.
And actually we would really want this criteria to stay.

[semteacher]

@gemguardian Thank you for information, you are very helpfull.

1. Generally, after latest updates, even under Moodle 4.1 completion settings must looks like:
   
   "Require grade" has been disabled (removed) because of the way in which booking plugin implements completion (see Completion Condition not triggered #629 (comment))
   With all my apologies, but if absence of "Require grade" completion setting does not fulfill your expectations / requirements - you have to discuss this with our managers, please.
2. For some reasons I cannot reproduce described error on my dev Moodle 4.1 by now. Vaue "2" for the "completion" field of the "course_completion" table should be completely eleigible. I will continue my debugging attempts in order to solve this issue.

[semteacher]

@gemguardian UPD: I managed to reproduce error. You were right it is related to the value of "completiongradeitemnumber". Will prepare fix ASAP

[gemguardian]

@semteacher thank you!

@dasistwas I am tagging you in here due to the comment on the comment made that required grade is being removed.