Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoFarm use any hotbar item to break crops #822

Open
Lamby777 opened this issue May 15, 2023 · 12 comments · May be fixed by #846
Open

AutoFarm use any hotbar item to break crops #822

Lamby777 opened this issue May 15, 2023 · 12 comments · May be fixed by #846
Labels
area:inventory area:settings Improves the settings of existing features. category:blocks status:never-stale Prevents stalebot from marking this item as stale. type:enhancement New feature or request

Comments

@Lamby777
Copy link

Pickaxes (and probably other tools, not sure) with Fortune on them apply to crops, so AutoFarm could be made WAY more efficient by putting the crop in the offhand and using the main hand to break stuff, then allowing the user to switch whatever item like a Fortune III pickaxe into their main hand.

Not sure how complicated this'd be, though. I could give it a try, but I've never messed with any real inventory management hacks so I'd probably write really crappy code.

@Lamby777 Lamby777 changed the title AutoFarm use fortune tool AutoFarm use any hotbar item to break crops May 15, 2023
@Alexander01998
Copy link
Member

Hey @Lamby777,

Thanks for the suggestion! That sounds like a useful feature to have. We could add a setting that allows AutoFarm to detect Fortune tools and automatically use them for harvesting crops while keeping the seeds in the offhand.

I'm currently working on an InventoryUtils class as part of my AutoFish rewrite. This should make inventory management a lot easier once all of the inventory-related hacks use it.

After finishing the AutoFish rewrite, I might work on rewriting AutoFarm's inventory management next. This should make it feasible to implement the option you've suggested.

However, I would like to caution you against trying to modify AutoFarm's current code to work with the offhand. It might be a lot more complicated than it looks and could lead to unexpected issues. Let's wait until the new inventory management system is in place before implementing this feature.

Cheers!

@Alexander01998 Alexander01998 added type:enhancement New feature or request area:settings Improves the settings of existing features. category:blocks area:inventory labels May 16, 2023
@ThisTestUser ThisTestUser linked a pull request Jun 24, 2023 that will close this issue
@ThisTestUser
Copy link
Contributor

I managed to implement your idea, along with some other enhancements, in #846.

@Lamby777
Copy link
Author

So the inventory refactoring stuff is done now? Or should I still wait before doing any inventory-related stuff?

@ThisTestUser
Copy link
Contributor

Yeah, it looks like AutoFarm uses InventoryUtils now.

@github-actions
Copy link

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

  • They are duplicates of other issues
  • There is not enough demand
  • They are no longer relevant
  • There are not enough details

@Lamby777
Copy link
Author

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

  • They are duplicates of other issues
  • There is not enough demand
  • They are no longer relevant
  • There are not enough details

PR is still open

Copy link

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

  • They are duplicates of other issues
  • There is not enough demand
  • They are no longer relevant
  • There are not enough details

@Lamby777
Copy link
Author

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

  • They are duplicates of other issues
  • There is not enough demand
  • They are no longer relevant
  • There are not enough details

among us

Copy link

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

  • They are duplicates of other issues
  • There is not enough demand
  • They are no longer relevant
  • There are not enough details

@Lamby777
Copy link
Author

Lamby777 commented Feb 26, 2024

closable? is this still relevant? (ignore my deleted comment, i mixed this up with a different issue 💀)

Copy link

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

  • They are duplicates of other issues
  • There is not enough demand
  • They are no longer relevant
  • There are not enough details

@Lamby777
Copy link
Author

//

@Alexander01998 Alexander01998 added status:never-stale Prevents stalebot from marking this item as stale. and removed status:stale labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:inventory area:settings Improves the settings of existing features. category:blocks status:never-stale Prevents stalebot from marking this item as stale. type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants