Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullReferenceException on iOS when showing a popup and iPad changes orientation multiple times #86

Open
valdetero opened this issue Sep 27, 2018 · 0 comments

Comments

@valdetero
Copy link

I have a popup that inherits from SlidePopupView. (Its a progress spinner that I show between navigating pages). When it is showing, and the iPad changes orientation from Portrait to Landscape and back again, it throws a NullReferenceException.

It throws it here: https://github.com/XAM-Consulting/SlideOverKit/blob/master/SlideOverKit.iOS/SlideOverKitiOSHandler.cs#L326
_backgroundOverlay.Frame = new CGRect (0, 0, ScreenSizeHelper.ScreenWidth, ScreenSizeHelper.ScreenHeight);
because _backgroundOverlay is null.

I pulled the source into my project and added a quick null check right above it and didn't notice any adverse side affects.

Could this line
if(_backgroundOverlay != null)
be added right above it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant