Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In .github/workflow, bump gcc version to 12 (or later) and clang version to 16 (or later) #5153

Open
Bronek opened this issue Oct 8, 2024 · 0 comments
Labels
Feature Request Used to indicate requests to add new features Request for Comments

Comments

@Bronek
Copy link
Collaborator

Bronek commented Oct 8, 2024

Motivation

We cannot instantiate the instrumentation macros when using clang compiler version older than 16. Currently our workflow is using clang 14 (and gcc 11).

Even though in principle it is possible to create a new job which would instantiate instrumentation macros, by means of

  1. installing the required compiler version inside the workflow, then
  2. building all the dependencies with conan, and finally
  3. building rippled with the added -Dvoidstar=ON option

... the steps 1. and 2. would add an unnecessary load to the project actions. It is better to re-use the existing dependencies job in nix.yml, but for this to be useful we need to upgrade the clang compiler to version no older than 16. While we are at it, we can just as well upgrade gcc to version 12.

Since this would most likely involve upgrade of the build container to ubuntu 24.04 (Noble), we could just as well upgrade to clang-18 and gcc-14. I would suggest not, for parity with Apple macOS 15 (where clang-16 is the most recent version available) and Debian 12 (where clang-16 and gcc-12 are the most recent versions available)

@Bronek Bronek added Feature Request Used to indicate requests to add new features Request for Comments labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features Request for Comments
Projects
None yet
Development

No branches or pull requests

2 participants
@Bronek and others