Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The levelization.sh script counts as included files that are commented out #5193

Open
vlntb opened this issue Nov 18, 2024 · 2 comments
Open
Assignees

Comments

@vlntb
Copy link
Collaborator

vlntb commented Nov 18, 2024

Issue Description

The levelization.sh script counts as included files that are commented out. I.e.

 // #include <xrpld/app/ledger/Ledger.h>
 #include <xrpld/nodestore/detail/DatabaseNodeImp.h>
 //#include <xrpl/basics/TaggedCache.ipp>
 #include <xrpl/protocol/HashPrefix.h>

This is not very obvious and creates confusion for someone who is trying to investigate and resolve issues with dependencies.

The proposal: as a minimum, add simple checks for a single line comment//.

@ximinez
Copy link
Collaborator

ximinez commented Nov 18, 2024

So the idea is you're just commenting out the #include to test levelization, but not necessarily removing it permanently? Because if you're removing it, you should just delete it. It'll still exist in git history.

@vlntb
Copy link
Collaborator Author

vlntb commented Nov 19, 2024

So the idea is you're just commenting out the #include to test levelization, but not necessarily removing it permanently? Because if you're removing it, you should just delete it. It'll still exist in git history.

Yes, if I was removing it, it would not be a problem.

What caught me: I was investigating newly discovered circular dependency and wasn't sure what caused it. So I was commenting out newly added headers, trying to find the point where dependency was introduced and was running in circles because the script ignored the commented-out code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants