Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for empty transaction flags #434

Merged
merged 10 commits into from
Jul 6, 2023
Merged

Allow for empty transaction flags #434

merged 10 commits into from
Jul 6, 2023

Conversation

nkramer44
Copy link
Collaborator

Fixes #425

@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (7fc9af0) to head (4a869fa).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
.../xrpl4j/model/jackson/modules/FlagsSerializer.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #434      +/-   ##
============================================
+ Coverage     90.27%   90.30%   +0.02%     
- Complexity     1416     1432      +16     
============================================
  Files           276      277       +1     
  Lines          4104     4125      +21     
  Branches        339      339              
============================================
+ Hits           3705     3725      +20     
  Misses          279      279              
- Partials        120      121       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sappenin
sappenin requested changes Jun 29, 2023
View reviewed changes
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/NfTokenCreateOfferFlags.java Outdated Show resolved Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/AccountSetTransactionFlags.java Outdated Show resolved Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/TransactionFlags.java Outdated Show resolved Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/TransactionFlags.java Outdated Show resolved Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/TrustSetFlags.java Outdated Show resolved Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/codec/binary/BinarySerializationTests.java Show resolved Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/MultiSignedTransactionTest.java Outdated Show resolved Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/SignedTransactionTest.java Outdated Show resolved Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/json/EscrowJsonTests.java Show resolved Hide resolved
...-core/src/test/java/org/xrpl/xrpl4j/model/transactions/json/NfTokenCreateOfferJsonTests.java Show resolved Hide resolved
@nkramer44 nkramer44 requested a review from sappenin July 5, 2023 17:05
@nkramer44 nkramer44 merged commit 15be398 into main Jul 6, 2023
@nkramer44 nkramer44 deleted the nk/425-empty-tx-flags branch July 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappenin sappenin sappenin approved these changes

@nhartner nhartner Awaiting requested review from nhartner nhartner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for empty/omitted transaction flags
2 participants
@nkramer44 @sappenin