Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to fetch Purchase Orders when using numeric PurchaseOrderNumber #251

Open
dretsa opened this issue Sep 21, 2021 · 0 comments
Open
Assignees

Comments

@dretsa
Copy link

dretsa commented Sep 21, 2021

SDK you're using (please complete the following information):

  • Version 2.8.1
  • Using custom connections

Describe the bug

Client can not fetch purchase order by PurchaseOrderNumber if it's numeric.

It must be a data type bug, but it seems like an API bug rather than the wrapper library bug, but I don't have access to Xero developer forums because you need to pay for that!

To Reproduce
Steps to reproduce the behavior:

  1. Create a purchase order with a numeric PurchaseOrderNumber - eg. "19200"
  2. Try to fetch if
<?php
[$po] = $this->accountingApi()->getPurchaseOrderByNumber('', '19200');
  1. You get a 404 error
  2. Ament the entry and add a letter to the PurchaseOrderNumber - eg. "A19200"
  3. Try to fetch
  4. It works now

Expected behavior
Correctly fetched purchase order by it's PurchaseOrderNumber when it's numeric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants