Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employee missing properties (NI category) #273

Open
csnuknet opened this issue Apr 12, 2022 · 1 comment
Open

Employee missing properties (NI category) #273

csnuknet opened this issue Apr 12, 2022 · 1 comment
Assignees

Comments

@csnuknet
Copy link

SDK you're using (please complete the following information):

  • Version [e.g. 1.x.x]

Describe the bug
When using the latest PHP SDK the following properties aren't exposed but are present in the returned response (as validated with the API explorer), these attributes also do not seem to be present in the Open API spec used to generate the SDK.

"niCategory": "A", "niCategories": [ { "startDate": null, "niCategory": "A", "niCategoryID": 1657128 } ], "employeeNumber": "10",

To Reproduce

Call ->getEmployee() on the SDK vs a direct call to the endpoint. https://api.xero.com/payroll.xro/2.0/employees/{employeeID}

Expected behavior
Provide feature parity with the endpoint response data, thus exposing the properties.

@pumpkinball
Copy link
Contributor

Hi @csnuknet yes, it does appear to be missing this niCategories array. I'm just waiting for confirmation over the exact properties of the array, and then we'll add into the OpenAPI spec for all languages, and then we'll generated the next PHP SDK with it in all being well.
Thanks for finding it!

@pumpkinball pumpkinball self-assigned this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants