Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Asset Serial Number and Warranty Expiry Date in get_assets API Response #123

Open
Jarred-VIPER opened this issue Oct 27, 2023 · 3 comments

Comments

@Jarred-VIPER
Copy link

Jarred-VIPER commented Oct 27, 2023

Issue Description:
When using the get_assets API endpoint in the Xero API to retrieve asset information, the response is missing the serial_number and warranty_expiry_date fields. However, when using the get_asset API with a specific asset_id, these fields are present in the response.

Steps to Reproduce:

Make a call to the get_assets endpoint with the required parameters (e.g., xero_tenant_id, xero_status, page, page_size).
Inspect the response for the presence of the serial_number and warranty_expiry_date fields.
Expected Behavior:
The get_assets API response should include the serial_number and warranty_expiry_date fields for each asset, providing comprehensive information about the assets.

Actual Behavior:
The serial_number and warranty_expiry_date fields are missing from the get_assets API response, making it necessary to use the get_asset API with a specific asset_id to retrieve this information.

API Call:
xero_assets = asset_api.get_assets(xero_tenant_id, xero_status, page, page_size,)

Sample Output:
{
'asset_id': 'fec39a7b-198f-4ada-abbd-175429eac520',
'asset_name': 'Dozer',
'asset_number': 'DZ003',
'serial_number': None,
'warranty_expiry_date': None,
}

Screenshot:
Screenshot from 2023-10-27 18-40-32

@github-actions
Copy link

PETOSS-358

@github-actions
Copy link

Thanks for raising an issue, a ticket has been created to track your request

@Sallyhornet
Copy link

This is by design, a GET all call gives a summary response, the GET asset by id gives more details.

The example responses for the different calls are listed here https://developer.xero.com/documentation/api/assets/assets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants