Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2023.2] CONFIG_FILE and CONFIG_TMPL variables in makefile of examples #194

Open
brucebenedictus opened this issue Mar 7, 2024 · 1 comment

Comments

@brucebenedictus
Copy link

Hi,

I want to run the the HLS examples in the 2023.2 branch. The makefile in the examples use the environment variable CONFIG_FILE and CONFIG_TMPL.
My infrastructure uses these environment variables already.

Would it be possible not to check if the variables are already set?

@vermaete
Copy link

vermaete commented Mar 7, 2024

just to append to the issue of Bruce

The issue here is that gitlab-ci is using the CONFIG_FILE variable too.
https://docs.gitlab.com/runner/commands/#configuration-file
And probably many others.

Putting a kind of namespacing to the global Vitis variables (e.g. 'xlnx_' or 'vitis_') could solve this.

br

vt-lib-support pushed a commit that referenced this issue Nov 29, 2024
b0c9240 Merge pull request #195 from FaaSApps/next
56df2a0 Merge pull request #194 from ryanw/next
e0f6dd5 Update README.md
1b91b17 Update README.md
0fbe7c4 Merge pull request #193 from ryanw/next
527c04a  recovery mistakenlly change from 23 to 24
da4f111 Copyright © 2019–2024
9103a09 Update README.md
0a88cb9 Update README.md
e6d9056 Update README.md
b09044c Update README.md
e15c5d9 Update README.md
4109f28 Update README.md
2d50067 fix 22.2 TO 24.2  CR-1221872
72c4df4 Merge pull request #192 from yunleiz/doc2024
a5ab68b [doc] rm doc for CR-1220255
e88f6e3 Merge pull request #191 from yunleiz/doc2024
3284dd9 [doc] backup backgroud pages for CR-1220255
aeb66ff Merge pull request #190 from ryanw/next
d762c8d Merge branch 'FaaSApps:next' into next
4f4e5a3 fixing CR-1209088
7f92b57 Merge pull request #183 from RepoOps/update_vitis_json_0810
042a973 Merge pull request #187 from ryanw/next
f992308 remove third-part web links in sresources.rst
801b1e2 keep on setting larger time for test
3c5a824 fixed description.json issue
b7ec90a max_time_min from 300 to 470 for scanline in L2 and L3
9d3dca4 to fix CR-1216091
b94df90 Merge pull request #186 from RepoOps/update_makefile_0929
b8f2bc9 fix
7246c62 fix
61a3d8f update Makefile
5277cb8 Merge pull request #185 from jingt/CR-1203008
4742e39 remove error of CR-1203008
26a593f Merge pull request #180 from RepoOps/update_20240617-183706
a83081e clean vitis case description json
710bf2d updateJenkinsfile
011a328 change 2024.1_stable_latest to 2024.2_stable_latest

Co-authored-by: sdausr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants