Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LORWAN FSK not initialised as false #231

Open
jonnytest1 opened this issue Feb 29, 2024 · 1 comment
Open

LORWAN FSK not initialised as false #231

jonnytest1 opened this issue Feb 29, 2024 · 1 comment

Comments

@jonnytest1
Copy link

jonnytest1 commented Feb 29, 2024

already fixed in source repo but not in the current version of this one

https://github.com/jgromes/RadioLib/blob/master/src/protocols/LoRaWAN/LoRaWAN.h#L776C4-L776C22

this is for the s3 branch

@jonnytest1
Copy link
Author

jonnytest1 commented Feb 29, 2024

https://github.com/Xinyuan-LilyGO/TTGO_TWatch_Library/blob/t-watch-s3/examples/radio/LoRaWAN/LoRaWAN_End_Device/LoRaWAN_End_Device.ino
additional fix: the beinOTAA method can return a mode like RADIOLIB_LORAWAN_MODE_OTAA which i think isnt an error

actually i think the "restore" method shouldnt return afterwards at all 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant