Skip to content
This repository has been archived by the owner on Apr 23, 2019. It is now read-only.

Pickup new node_modules/ when they are installed #136

Open
irae opened this issue Jun 12, 2017 · 0 comments
Open

Pickup new node_modules/ when they are installed #136

irae opened this issue Jun 12, 2017 · 0 comments

Comments

@irae
Copy link
Collaborator

irae commented Jun 12, 2017

During development, sometimes you git pull changes and need to install a new package. I am not proposing Mendel should install the packages, but I think we should track the dependencies.

IIRC, when filesystem watcher scans folders, we don't wildcard watch for node_modules for performance reasons. But we do watch every file we require. I am thinking to fix this, we just need to watch for new node_modules/ we know are missing.

For instance, this is the proposed workflow:

  1. Git pull something, a new file or existing file within variational or base folder requires a new dependency foo.

  2. Dependency foo is not found

    2.1. Currently I think we do not watch for the dependency foo.
    2.2. Suggesting we add foo to a list of dependencies we are looking for and watch node_modules/

  3. User installs foo manually (or maybe they have a grunt task for it).

    3.1. Currently user needs to stop daemon and start again
    3.2. Suggesting we get events on node_modules folder, if it matches array of missing dependencies (in example array is ['foo']) we then require the entry and start watching for changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant