Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle-switch-mode during setup procedure #203

Closed
ted-miller opened this issue Jan 23, 2024 · 8 comments · Fixed by #212 or #229
Closed

Cycle-switch-mode during setup procedure #203

ted-miller opened this issue Jan 23, 2024 · 8 comments · Fixed by #212 or #229
Milestone

Comments

@ted-miller
Copy link
Collaborator

Re: #201 (reply in thread)

Need to add this to setup procedure. Perhaps we can also detect this in real time via CIO.

(I vaguely recall this being an issue in the past. But I can't find anything about it in the repos.)

@ted-miller ted-miller added this to the 0.2.0 milestone Jan 23, 2024
@ted-miller
Copy link
Collaborator Author

Looks like we can detect with these:

image

@gavanderhoorn
Copy link
Collaborator

@ted-miller: did we forget to add something to the setup documentation about this?

@ted-miller
Copy link
Collaborator Author

It looks like I added to the motoros1 wiki, but didn't do it here.

@ted-miller ted-miller reopened this Mar 18, 2024
@ted-miller
Copy link
Collaborator Author

It just occurred to me that there is an API for mpSetCycle.

@yai-rosejo @gavanderhoorn

I vote that instead of documenting the step of setting cycle, we should automate it. Right after we enable servos, we can set cycle and then start the INIT_ROS job.

Thoughts?

@gavanderhoorn
Copy link
Collaborator

Hm. Changing 'global' controller configuration for a single application in an automagic way?

Not sure.

@ted-miller
Copy link
Collaborator Author

It's not global. It's instantaneous.

When the user switches the key-switch, the robot's "saved" configuration is restored.

(At least I think that's true. Need to verify.)

@gavanderhoorn
Copy link
Collaborator

If that's true (ie: it reverts) automating it seems like it would improve UX.

related btw: I've never had my YRC1 configured with continuous and never really ran into any issues. Was I just lucky?

@ted-miller
Copy link
Collaborator Author

The default value is cycle, which will run one cycle of the job.

For the normal use-case this should work. Normally, the job should only 'finish' if traj_mode is stopped. In that case, you'd have to re-enable the job from the start.

So really, I now think that #212 may be too restrictive. (I've just now started getting these errors for the first time.) It should allow auto or cycle. But, this point is moot if we automate it.

@ted-miller ted-miller linked a pull request Mar 27, 2024 that will close this issue
@gavanderhoorn gavanderhoorn modified the milestones: 0.2.0, 0.1.3 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants