Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ROS 2 version in AppInfo on controller #126

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

gavanderhoorn
Copy link
Collaborator

@gavanderhoorn gavanderhoorn commented Aug 16, 2023

I noticed we actually don't have any way of determining which ROS 2 version is supported by which MR2 binary, other than asking the user.

Now that #109 is merged, it's possible to derive this information from the name of the .out, but that's not very convenient.

This PR changes the way MotoROS2 registers itself with the "application information" infrastructure to add the ROS 2 codename to the version nr/string.

It changes the line in the PANELBOX.LOG from :

//MOTOPLUS APP
01: MotoROS2                         0.1.0            micro-ROS based ROS 2 interface 

to:

//MOTOPLUS APP
01: MotoROS2 (humble)                0.1.0            micro-ROS based ROS 2 interface 

From this, it's clear MotoROS2 version 0.1.0 supporting ROS 2 Humble is installed on this controller.

@gavanderhoorn gavanderhoorn added this to the 0.1.1 milestone Aug 16, 2023
@gavanderhoorn
Copy link
Collaborator Author

I've kept this a draft, as it requires updates to the libmicroros distribution .zips.

Until that's done, CI will fail.

I'll probably update the .zips currently attached to the 0.1.0 release.

@gavanderhoorn
Copy link
Collaborator Author

gavanderhoorn commented Aug 16, 2023

As an alternative, we could put the ROS 2 codename string in the AppName field (it's longer), but that didn't seem right, as the ROS 2 codename isn't part of the name of the application itself.


Edit: I've changed the implementation to add the codename to AppName. This fits better when looking at the M+ application list details on the PP.

Facilitates diagnosis of issues based on PANELBOX.LOG data.
Ever. We just truncate the strings in that case.

Just use the M+ SDK defined constants for field lengths (mpLegAPI00.h).
@gavanderhoorn gavanderhoorn force-pushed the app_info_include_ros_version branch from cbd8a96 to eeebd26 Compare August 17, 2023 14:47
@gavanderhoorn gavanderhoorn marked this pull request as ready for review August 17, 2023 18:23
@gavanderhoorn
Copy link
Collaborator Author

With the updated M+ libmicroros distribution .zips CI now succeeds.

Copy link
Collaborator

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ted-miller ted-miller merged commit c9a9670 into main Aug 17, 2023
@ted-miller ted-miller deleted the app_info_include_ros_version branch August 17, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants