reset_error: print correct char field, not struct #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `rosidl_runtime_c__String` is a `struct`, not a plain `char*`. On some architectures/controller platforms it's OK to pass a pointer to the `struct`, as the first member is the `char*`, but at least on FS100 this doesn't work and results in garbage output to the debug log.
|
There might be more places where we do this, but I happened to notice this one and it made me distrust the FS1 build enough to fix it. |
ted-miller
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
rosidl_runtime_c__Stringis astruct, not a plainchar*.On some architectures/controller platforms it's OK to pass a pointer to the
struct(apparently), as the first member is thechar*, but at least on FS100 this doesn't work and results in garbage output to the debug log.