This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Fix gh acceptance build #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only problems happened in our acceptance test suite, where we run everything from Docker containers. The main issue happened with how we were setting up our testing suite's virtual environment (in
docker/test/Dockerfile) but I also took this chance to migrate to Ubuntu Bionic (18.04) and clean up some other sub-optimal things in our Dockerfiles.Note that the GH action change is meant to reduce duplicate test runs when creating/updating a CR (see #270) and also ensure that all 3 test suites can run independently - so you still get test results for all 3 even if one fails.
This doesn't change the actual package we distribute, just how we test it.