Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for soundtypes #27

Open
rlnt opened this issue May 1, 2020 · 4 comments
Open

Support for soundtypes #27

rlnt opened this issue May 1, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@rlnt
Copy link

rlnt commented May 1, 2020

Would be nice if soundtypes would be supported in the dump probe creates.

ContentTweaker has a feature that allows modpack makers to create custom blocks.
You can define a block sound type with a bracket handler. These bracket handlers are not yet dumped and therefor ZenScript shows an error that it's not available.

Example code:

var infusionBlock = VanillaFactory.createBlock("infusion_block", <blockmaterial:rock>);
infusionBlock.setBlockSoundType(<soundtype:stone>);
infusionBlock.register();
@Yesterday17
Copy link
Owner

Yeah, that's ContentTweaker, which uses a new loader as I know.
It would be a new feature, which requires an update of both Probe and ZenScript.

Transferring to the extension repo for further development.
But recently(more precisely, before May.20), I have many things to do and maybe can only do some bug fixes for the extension. :)

@Yesterday17 Yesterday17 transferred this issue from Yesterday17/Probe May 1, 2020
@Yesterday17 Yesterday17 self-assigned this May 1, 2020
@Yesterday17 Yesterday17 added the enhancement New feature or request label May 1, 2020
@Landiie
Copy link

Landiie commented Jun 20, 2020

been struggling with this too, really wish there was support for soundtype dumping. Is there anyway i could hide the errors for the soundtypes in the meantime? its pretty jarring D:

EDIT: nevermind! #ignoreBracketErrors works c:

hope this soundtype enhancement can be implemented soon! would be super cool

@Yesterday17
Copy link
Owner

Yesterday17 commented Jun 24, 2020

A new strategy will be introduced to ZenScript in the next release to help the extension distinguish whether a bad bracketHandler is an unknown type.

What you need to do only is to disable modIdItemCompletion in options. This might be frustrating if you're used to using bracketHandler such as <minecraft:white_wool> to refer to white wool without the item: prefix(as it's optional). You may need to add all those prefixes manually.

The reason is quite simple: if you use <modid:item_name> to refer to items, it's impossible for the extension to know whether modid is an unknown type of bracketHandler, or just a mistyped normal bracketHandler.

In short, after disabling modIdItemCompletion, no error would be produced by unknown bracketHandlers.

@Landiie
Copy link

Landiie commented Jun 26, 2020

Ive disabled the modIdItemCompletion although i use your probe mod and i do quite enjoy the auto-fill features it has so i can do scripts without having to open the game sometimes, its really a time saver considering my pack's load times!

So ill just stick with putting #ignoreBracketHandlers on my script though until there is some workaround or like you said; will just flag the bracket as unknown rather than bad so there is no errors. Thanks for the input though!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants