Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-Game: Add a new function matrix_inverse() for inverting a matrix #2960

Closed
DragoniteSpam opened this issue Sep 19, 2023 · 5 comments
Closed

In-Game: Add a new function matrix_inverse() for inverting a matrix #2960

DragoniteSpam opened this issue Sep 19, 2023 · 5 comments
Assignees
@yymrennie @alicemoretti @YYBartT
Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one)
Milestone
2024.11

Comments

@DragoniteSpam
Copy link

DragoniteSpam commented Sep 19, 2023 •
edited by YYDan
Loading

Is your feature request related to a problem?

Implementing matrix_inverse in gml is slow

Describe the solution you'd like

A runtime function to invert a matrix

Describe alternatives you've considered

Doing it yourself (or pilfering snidr's code for it, anyway), which is slow

Additional context

I think I submitted this in the old feature request form, but apparently it didn't get migrated.
@DragoniteSpam DragoniteSpam added the feature request New feature (or a request for one) label Sep 19, 2023
@iampremo iampremo transferred this issue from another repository Jan 9, 2024
@rwkay rwkay added this to the 2024.11 milestone Oct 30, 2024
@rwkay rwkay moved this to Todo in Team Workload Oct 30, 2024
yymrennie pushed a commit to YoYoGames/GameMaker-HTML5 that referenced this issue Oct 31, 2024
Implementation of YoYoGames/GameMaker-Bugs#2960
ab51a70
@yymrennie
Copy link

A native matrix_inverse() function has now been added in 2024.11

@github-project-automation github-project-automation bot moved this from Todo to Done in Team Workload Oct 31, 2024
@YYDan YYDan changed the title matrix_inverse (and other matrix functions, if you're feeling ambitious) In-Game: Add a new function matrix_inverse() for inverting a matrix Oct 31, 2024
@YYDan
Copy link
Collaborator

YYDan commented Oct 31, 2024

Removed the additional content for things which have not been done as part of this change

@gurpreetsinghmatharoo gurpreetsinghmatharoo added the documentation Improvements or additions to documentation are required by this issue label Nov 1, 2024
@YYBartT YYBartT self-assigned this Nov 5, 2024
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Nov 5, 2024
@YYBartT
docs(general): Small changes to matrix function pages
48283d1 
YoYoGames/GameMaker-Bugs#2960
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Nov 11, 2024
@YYBartT
docs(general): add note about matrices being stored in arrays
84e25c0 
YoYoGames/GameMaker-Bugs#2960
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Nov 11, 2024
@YYBartT
docs(feature): Add a new function matrix_inverse() for inverting a ma…
502f486 
…trix

YoYoGames/GameMaker-Bugs#2960

* Added matrix_inverse() page
* Various other improvements to matrix function pages:
  * Changed the type "Matrix Array" to "Matrix", abstracting away the underlying type (similar to e.g. "Instance", "Surface", etc., which are stored in a "Handle")
  * Data Types: added a note under the "Arrays" section mentioning that matrices are stored in arrays
  * Matrix Functions page:
    * Grouped matrix functions according to their use, updated ToC accordingly
    * Documented that matrices are ordered column-major in arrays
    * Added a line to clarify that lines are the columns instead of the rows when splitting up an assignment over multiple lines
  * matrix_build() page: documented that matrices are ordered column-major in arrays, added note about matrices possibly ending up transposed in the shader
  * matrix_multiply() page: documented order of matrix multiplication on and added a second, copy-pastable example
  * matrix_set() page: listed the functions that can be used to create matrices of the various types, updated code example
  * matrix_get() and matrix_set() page: added proper short descriptions
  * Visual update of matrix function pages
@YYBartT
Copy link

YYBartT commented Nov 11, 2024

Added a new function page for matrix_inverse() to the manual as well as other improvements and additions to the matrix function pages, including the storage order of matrices in arrays and the order of matrix multiplication. Also added additional code examples to a few function pages.

@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Nov 11, 2024
@YYBartT YYBartT mentioned this issue Nov 11, 2024
Open
@alicemoretti alicemoretti self-assigned this Nov 12, 2024
@alicemoretti
Copy link
Contributor

Verified that the function has been added to IDE v2024.1100.0.685 Runtime v2024.1100.0.707 and it works as intended.

Waiting on the documentation being released before setting the status as verified.

@YYBartT YYBartT mentioned this issue Nov 19, 2024
Merged
@alicemoretti
Copy link
Contributor

Verified that a page for matrix_inverse has added to Manual Beta build #412 and is correct. Thank you

@alicemoretti alicemoretti moved this from Ready for QA to Verified in Team Workload Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yymrennie yymrennie

@alicemoretti alicemoretti

@YYBartT YYBartT

Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one)
Projects
Team Workload
Status: Verified
Milestone
2024.11
Development

No branches or pull requests
7 participants
@rwkay @DragoniteSpam @yymrennie @YYDan @gurpreetsinghmatharoo @alicemoretti @YYBartT