Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Editor 2: Matching brackets highlight is too subtle and lacks a Preference to control the colour used #8096

Closed
gnysek opened this issue Oct 23, 2024 · 4 comments
Assignees
Labels
ide-bug Bugs with the GameMaker IDE
Milestone

Comments

@gnysek
Copy link
Contributor

gnysek commented Oct 23, 2024

Description

In CE1, matching brackets are highlighted with cyan bg:

obraz

In CE2, if "Rainbow brackets" are turned off, it's nearly not visible where matching bracket is, they have some gray bg:

obraz

Expected Change

No response

Steps To Reproduce

  1. Start GameMaker
  2. Put cursor after {, }, ( or )
  3. Compare differences between CE1 and CE2 in that case, as on images above.

How reliably can you recreate this issue using your steps above?

Always

Which version of GameMaker are you reporting this issue for?

2024.1100 (Betas)

Which operating system(s) are you seeing the problem on?

Windows 11

@gnysek gnysek added the ide-bug Bugs with the GameMaker IDE label Oct 23, 2024
@stuckie stuckie moved this from Triage to Backlog in Team Workload Oct 23, 2024
@KormexGit
Copy link

This color is also missing from themes, you can change the main selection color and the line selection color, but not the selection match color:

image

@skud92
Copy link

skud92 commented Oct 23, 2024

CE1 is more readable, we should use this and have the option to change in preferences if the user wishes

@gnysek
Copy link
Contributor Author

gnysek commented Oct 23, 2024

Yes, it's more readable in CE1, with selected text and default colors, it's even hard to notice that brackets are highlighted in CE2:
obraz

@zreedy zreedy added this to the 2025.1 milestone Nov 19, 2024
@zreedy zreedy moved this from Backlog to Todo in Team Workload Nov 21, 2024
@zreedy
Copy link

zreedy commented Dec 9, 2024

This was fixed with #5215
Please see final comment for details.

@zreedy zreedy closed this as completed Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Workload Dec 9, 2024
@YYDan YYDan changed the title Code Editor 2: matching brackets in CE2 are highlighted in a very subtle way compared to CE1 Code Editor 2: Matching brackets highlight is too subtle and lacks a Preference to control the colour used Dec 9, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide-bug Bugs with the GameMaker IDE
Projects
Status: Ready for QA
Development

No branches or pull requests

5 participants