Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the TYPO3_REQUEST for getting moduleData within PageLayoutHeader #589

Open
2 tasks done
RinyVT opened this issue Dec 12, 2024 · 0 comments
Open
2 tasks done

Use the TYPO3_REQUEST for getting moduleData within PageLayoutHeader #589

RinyVT opened this issue Dec 12, 2024 · 0 comments

Comments

@RinyVT
Copy link
Collaborator

RinyVT commented Dec 12, 2024

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

Within the PageLayoutHeader the BackendUtility::getModuleData is being used.
The underlying functionality sets the module data properties (function, language, constant_editor_cat) to null if nothing is present in the backend user's uc.
This causes a problem if the default values for the web_layout module are changed, for example with the PSR-14 event https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Events/Events/Backend/BeforeModuleCreationEvent.html#BeforeModuleCreationEvent

Please describe what you expected to happen and why.

Starting from 12, the moduleData is present in the TYPO3_REQUEST. The advantage of that is that it merges the default values from the backend module with the ones in the uc.

This should be changed in the getLanguageId method of PageLayoutHeader.
If the languageId is -1 ("All Languages") it should return 0 just like within content elements.

Technical info

  • TYPO3 version: 12.4.24
  • Yoast SEO version: 10.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant