From 8920567020c5dd9845ed769971218faaa6ec59f6 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sat, 21 Dec 2024 16:04:00 +0100 Subject: [PATCH] GH Actions: add actionlint job This job checks the GH Actions workflows against syntax errors and other problems. Includes minor fixes to pre-existing workflows to allow the build to pass. --- .github/workflows/cs.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cs.yml b/.github/workflows/cs.yml index c80bc68..9dbc1e8 100644 --- a/.github/workflows/cs.yml +++ b/.github/workflows/cs.yml @@ -11,7 +11,7 @@ on: - 'composer.lock' - '.phpcs.xml.dist' - 'phpcs.xml.dist' - - '.github/workflows/cs.yml' + - '.github/workflows/**' pull_request: paths: - '**.php' @@ -19,7 +19,7 @@ on: - 'composer.lock' - '.phpcs.xml.dist' - 'phpcs.xml.dist' - - '.github/workflows/cs.yml' + - '.github/workflows/**' # Allow manually triggering the workflow. workflow_dispatch: @@ -30,6 +30,10 @@ concurrency: cancel-in-progress: true jobs: + actionlint: + name: 'Lint GH Action workflows' + uses: Yoast/.github/.github/workflows/reusable-actionlint.yml@main + checkcs: name: 'Check code style' runs-on: ubuntu-latest @@ -44,11 +48,11 @@ jobs: BASE_REF: ${{ github.base_ref }} run: | if [ "${{ github.event_name }}" == "pull_request" ]; then - echo "NAME=$BASE_REF" >> $GITHUB_OUTPUT - echo "REF=origin/$BASE_REF" >> $GITHUB_OUTPUT + echo "NAME=$BASE_REF" >> "$GITHUB_OUTPUT" + echo "REF=origin/$BASE_REF" >> "$GITHUB_OUTPUT" else - echo 'NAME=develop' >> $GITHUB_OUTPUT - echo "REF=origin/develop" >> $GITHUB_OUTPUT + echo 'NAME=develop' >> "$GITHUB_OUTPUT" + echo "REF=origin/develop" >> "$GITHUB_OUTPUT" fi - name: Fetch base branch @@ -83,7 +87,7 @@ jobs: set +e composer check-cs-thresholds exitcode="$?" - echo "EXITCODE=$exitcode" >> $GITHUB_OUTPUT + echo "EXITCODE=$exitcode" >> "$GITHUB_OUTPUT" exit "$exitcode" # Check the codestyle only of the files which were changed in the current branch.