Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbl/1036970 lax check for duplicate subblocks #2

Merged

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Oct 20, 2023

Description

  • Use a new option for the CZIWriter to ignore duplicate subblocks.
  • The command line application is given a new option to enable/disable "ignoring duplicate subblocks". Default is "on".
  • In the C-API layer, the option is enabled always.
  • in addition, a new option allowing to overwrite an existing file is added to the command line application.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of czicompress following the README (Versioning) depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team October 20, 2023 21:21
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Oct 20, 2023
README.md Outdated Show resolved Hide resolved
lib/include/commandlineoptions.h Outdated Show resolved Hide resolved
capi/capi.cpp Outdated Show resolved Hide resolved
@ptahmose ptahmose requested a review from m-ringler October 23, 2023 09:44
@ptahmose ptahmose merged commit 8fb5dc2 into ZEISS:main Oct 23, 2023
7 checks passed
@ptahmose ptahmose deleted the jbl/1036970-lax_check_for_duplicate_subblocks branch October 23, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants