Write channel id and name to display settings nodes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 66.01% 66.18% +0.16%
==========================================
Files 85 85
Lines 10664 10705 +41
==========================================
+ Hits 7040 7085 +45
+ Misses 3624 3620 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ptahmose
reviewed
Aug 12, 2024
ptahmose
reviewed
Aug 12, 2024
ptahmose
reviewed
Aug 12, 2024
|
bumping the version-number (in CMakeLists.txt) and an entry in version-history,markdown would be missing. |
* when adding the display-settings with the metadata-builder, by default copy the attributes "Id" and "Name" from the corresponding channel in the channels-node * add an overload of MetadataUtils::WriteDisplaySettings which allows to control what is put into the respective "Id" and "Name" attributes
|
I added a proposal for a revised version. The idea here is:
|
The line `std::tuple<std::string, std::tuple<bool, std::string>> channelIdAndName;` has been removed from the loop that processes channel display settings. This indicates that the variable `channelIdAndName` is no longer necessary or its usage has been refactored out of this section of the code.
m-aXimilian
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends libczi to set the Id and Name attributes in the DisplaySettings of the image metadata. For more informatione please see the description of the corresponding issue.
Fixes #105
Type of change
How Has This Been Tested?
Ths PR adds a unit test. Furthermore the changes were tested with a developer build of pylibczirw and manually verifying that the resulting image is loaded in ZEN as expected.