Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner - pause/play #531

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Banner - pause/play #531

merged 2 commits into from
Dec 15, 2024

Conversation

rtrembecky
Copy link
Collaborator

@rtrembecky rtrembecky commented Dec 14, 2024

outdated obrazky:
image
image

Copy link
Member

@Matushl Matushl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zvazil by som kebyze sa to pauzuje na klik na banner, to play/pause button je tak taky dost out of place

@rtrembecky
Copy link
Collaborator Author

ja som sa bal toho kliku na banner, akoze... preco by si na to vlastne ako user klikal. skor by som cakal, ze sa ti nieco nove otvori, ako ze sa ti to zastavi 🤔

@Matushl
Copy link
Member

Matushl commented Dec 14, 2024

Tak v prvom rade tam mozes tad cursor on hover a keby sme velmi chceli tak tam mozes dat tooltip ktory bude hovorit "pozastavit/pustit" alebo nieco take ked velmi chces :-D

Akoze ked cloveka to bude otravovat tak na to aspon hoverne myskou podla mna

@rtrembecky
Copy link
Collaborator Author

som myslel ze to tam prepasujem takto a nastartujem diskusiu 😄 ale mozes sa spytat zvysku na chate, ako by si to idealne predstavovali. a ci sa ti ma zachovat running/paused state pri navigacii medzi strankami 🤔

@Matushl
Copy link
Member

Matushl commented Dec 14, 2024

chata sa zhodla, ze ked to raz pauznes, tak nech to zostane pauznute ale ze nech uz to je plne textu, nie ze bude ten text cakat za obrazovkou na vstup

taktiez sa zhodli ze play a pause button nasa designerna nerozchodi, ale mozes to skusit pusnut s tlacitkami aspon budu ludia nuteny hladat alternativne riesenie potom :-D

@Matushl
Copy link
Member

Matushl commented Dec 14, 2024

sme sa s mihalom, petom a tak zhodli, ze to chceme skusit bez pause buttona, no a idealne teda perzistovat to ze je pauznuty

@rtrembecky
Copy link
Collaborator Author

otazka len uz ze na aky cas persistovat... napr. kym som v appke, ale po refreshi pojde znovu? alebo ani po refreshi? a v inych taboch? 😅 dam reset po refreshi zatial, no

@rtrembecky rtrembecky force-pushed the banner-pause-play-button branch from 318ed35 to 5213792 Compare December 15, 2024 10:32
@rtrembecky rtrembecky force-pushed the banner-pause-play-button branch from 5213792 to df99dc7 Compare December 15, 2024 10:43
Copy link
Member

@Matushl Matushl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOP 💯

@rtrembecky rtrembecky merged commit 66315d1 into master Dec 15, 2024
1 check passed
@rtrembecky rtrembecky deleted the banner-pause-play-button branch December 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants