Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Async: Get tests working again #5

Open
helje5 opened this issue Nov 12, 2017 · 1 comment
Open

Async: Get tests working again #5

helje5 opened this issue Nov 12, 2017 · 1 comment

Comments

@helje5
Copy link
Member

helje5 commented Nov 12, 2017

Would be cool to have tests ;-)

Related to swift-server#96:

It would be awesome if you would get the tests working again. I don't plan to work on such any time soon, so feel free to do anything you want!

Adjusting the tests might be challenging, because, well, they need to be asynchronous. For Noze.io I have a helper class which tries to deal with the asynchronicity, not sure whether it might help you or not (or even whether this is the correct way to test that stuff): NozeIOTestCase.swift

The other hurdle is that I made the HTTPResponseWriter concrete (i.e. it is not a protocol anymore). I suppose that makes some mocking hard. We could change it back to a protocol, but I think it was suggested that we should avoid them for performance reasons.

@carlbrown
Copy link

Added #13 for Mac tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants