Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exception handling #28

Open
Zeebrow opened this issue Jul 12, 2022 · 0 comments
Open

Improved exception handling #28

Zeebrow opened this issue Jul 12, 2022 · 0 comments

Comments

@Zeebrow
Copy link
Owner

Zeebrow commented Jul 12, 2022

Exceptions need to be handled accurately and consistently. (I started handling them after the app was pretty much done)

  • logger should emit debug if the action did not produce an exception
  • warning when action didn't do what it was intended to, but should not stop the app from finishing its operation
    • e.g. a security group doesn't exist when we go to destroy it
  • error when action didn't do what it was intended to, and app should not continue its operation
    • e.g. IAM permissions
    • generally seem to be caught in AWSApp.py as opposed to specific resources

There's too many to count at this point. Mark 'em as you see 'em.

@Zeebrow Zeebrow changed the title improved exception handling Improved exception handling Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant