Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

177 - setup percy. #184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

177 - setup percy. #184

wants to merge 2 commits into from

Conversation

robinlarsson
Copy link
Collaborator

@robinlarsson robinlarsson commented Mar 25, 2021

#177

Percy, "Your all-in-one visual review platform".

It's a quick way to get visual graphic testing that could assist with checking that the all the games looks the same as the previous commit.

Generously provided with 5000 free screenshots per month.

Run with:
percy snapshot snapshots.js

@robinlarsson robinlarsson added the build-and-test Issues related to building the project and all kinds of automatic tests label Mar 25, 2021
@robinlarsson robinlarsson self-assigned this Mar 25, 2021
@robinlarsson
Copy link
Collaborator Author

robinlarsson commented Mar 28, 2021

It's not always the same amount of players when using the try game feature. So, perhaps not suitable using Percy with too much dynamics in the data.

image

@robinlarsson robinlarsson changed the title WIP - 177 - setup percy. 177 - setup percy. Mar 28, 2021
@robinlarsson robinlarsson requested a review from Zomis March 28, 2021 12:23
@robinlarsson robinlarsson changed the base branch from master to main April 8, 2021 18:41
@Zomis
Copy link
Owner

Zomis commented Jan 31, 2022

Sorry for taking so long to look at this!

Can you add a short note about what Percy is/does and most importantly: How to run it? If I'm not mistaken, it's for taking screenshots of how the frontend looks, and IIRC, compare the screenshots to make sure nothing has changed?

@robinlarsson
Copy link
Collaborator Author

The issue #177 hold some information that I copied over to this PR.

Do you want me to write in a README file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-and-test Issues related to building the project and all kinds of automatic tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants