Update logger to facilitate the use of global logger #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emmanuelm41
approved these changes
Oct 30, 2024
jleni
reviewed
Oct 30, 2024
Sure, we may try this with cursor?? would be pretty nice. I've just added a pretty basic README |
|
@rawmind0 yes, using cursor is what I meant!! |
|
Ok, let me check if i can do it. |
|
Logger README has been updated using ia |
emmanuelm41
reviewed
Oct 31, 2024
pkg/logger/README.md
Outdated
| ## Installation | ||
|
|
||
| ```go | ||
| go get -u go.uber.org/zap |
There was a problem hiding this comment.
go get zap? I don't think this is correct!
There was a problem hiding this comment.
You are right. Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the chance to use global zap logger within the packages. Also some code cleanup has been done, like remove the logger mutex due to zap package already take care of them
🔗 zboto Link