Skip to content

Commit

Permalink
feat: change default build flags, and apply some updates (#124)
Browse files Browse the repository at this point in the history
* fix: set production build flag to 1 as default

* chore: bump app version

* feat: update snapshots

* feat: add ticket on Fee label

* feat: update zxlib

* feat: update snapshots

* feat: update zxlib and update snapshots

* feat: update zxlib version
  • Loading branch information
emmanuelm41 authored Oct 22, 2024
1 parent 7248d24 commit 8feb7fe
Show file tree
Hide file tree
Showing 187 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions app/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ include $(CURDIR)/../deps/ledger-zxlib/makefiles/Makefile.installer_script

include $(BOLOS_SDK)/Makefile.defines

# Set the default value for PRODUCTION_BUILD to 0 if not already defined
PRODUCTION_BUILD ?= 0
# Set the default value for PRODUCTION_BUILD to 1 if not already defined
PRODUCTION_BUILD ?= 1

$(info ************ TARGET_NAME = [$(TARGET_NAME)])

Expand Down
2 changes: 1 addition & 1 deletion app/Makefile.version
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ APPVERSION_M=4
# This is the minor version
APPVERSION_N=2
# This is the patch version
APPVERSION_P=1
APPVERSION_P=2
2 changes: 1 addition & 1 deletion app/src/parser.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ parser_error_t parser_getItem(uint8_t displayIdx,
}

case type_txfee: {
snprintf(outKey, outKeyLen, "Fee");
snprintf(outKey, outKeyLen, "Fee (ZEC)");
return parser_sapling_display_value(get_totalvalue(), outVal, outValLen, pageIdx, pageCount);
}

Expand Down
Binary file modified tests_zemu/snapshots/fl-1-tr-in-1-spend-2-sh-out/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-in-1-spend-2-sh-out/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-in-1-spend-2-sh-out/00004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-in-1-spend-2-sh-out/00005.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-in-1-tr-out-1-spend-2-sh-out/00005.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-out-1-spend-2-sh-out/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-out-1-spend-2-sh-out/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-out-1-spend-2-sh-out/00004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-1-tr-out-1-spend-2-sh-out/00005.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-2-spend-2-out/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-2-spend-2-out/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-2-spend-2-out/00004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-2-spend-2-out/00005.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-2-tr-in-2-tr-out/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-2-tr-in-2-tr-out/00003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-builder-addr-diff-to-inittx-addr/00005.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests_zemu/snapshots/fl-ext-more-sigs-than-needed-for-tx/00005.png
Binary file modified tests_zemu/snapshots/fl-ext-output-without-ext-spend-data/00005.png
Binary file modified tests_zemu/snapshots/fl-ext-sig-without-checkandsign/00000.png
Binary file modified tests_zemu/snapshots/fl-ext-sig-without-checkandsign/00001.png
Binary file modified tests_zemu/snapshots/fl-ext-sig-without-checkandsign/00004.png
Binary file modified tests_zemu/snapshots/fl-ext-sig-without-checkandsign/00005.png
Binary file modified tests_zemu/snapshots/fl-get-fvk-expert/00000.png
Binary file modified tests_zemu/snapshots/fl-get-fvk-expert/00001.png
Binary file modified tests_zemu/snapshots/fl-get-fvk-expert/00002.png
Binary file modified tests_zemu/snapshots/fl-get-fvk/00000.png
Binary file modified tests_zemu/snapshots/fl-get-fvk/00001.png
Binary file modified tests_zemu/snapshots/fl-get-fvk/00002.png
Binary file modified tests_zemu/snapshots/fl-get-ivk-expert/00000.png
Binary file modified tests_zemu/snapshots/fl-get-ivk-expert/00001.png
Binary file modified tests_zemu/snapshots/fl-get-ivk-expert/00002.png
Binary file modified tests_zemu/snapshots/fl-get-ivk/00000.png
Binary file modified tests_zemu/snapshots/fl-get-ivk/00001.png
Binary file modified tests_zemu/snapshots/fl-get-ivk/00002.png
Binary file modified tests_zemu/snapshots/fl-get-ovk-expert/00000.png
Binary file modified tests_zemu/snapshots/fl-get-ovk-expert/00001.png
Binary file modified tests_zemu/snapshots/fl-get-ovk-expert/00002.png
Binary file modified tests_zemu/snapshots/fl-get-ovk/00000.png
Binary file modified tests_zemu/snapshots/fl-get-ovk/00001.png
Binary file modified tests_zemu/snapshots/fl-get-ovk/00002.png
Binary file modified tests_zemu/snapshots/fl-mainmenu/00001.png
Binary file modified tests_zemu/snapshots/fl-mainmenu/00002.png
Binary file modified tests_zemu/snapshots/fl-mainmenu/00003.png
Binary file modified tests_zemu/snapshots/fl-mainmenu/00004.png
Binary file modified tests_zemu/snapshots/fl-not-using-ledger-rnd-for-tx/00000.png
Binary file modified tests_zemu/snapshots/fl-not-using-ledger-rnd-for-tx/00001.png
Binary file modified tests_zemu/snapshots/fl-not-using-ledger-rnd-for-tx/00004.png
Binary file modified tests_zemu/snapshots/fl-not-using-ledger-rnd-for-tx/00005.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0x1-expert/00000.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0x1-expert/00001.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0x1-expert/00002.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0x1/00000.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0x1/00001.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0x1/00002.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0xFF-expert/00000.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0xFF-expert/00001.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0xFF-expert/00002.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0xFF/00000.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0xFF/00001.png
Binary file modified tests_zemu/snapshots/fl-show_nullifier-0xFF/00002.png
Binary file modified tests_zemu/snapshots/fl-txinit/00000.png
Binary file modified tests_zemu/snapshots/fl-txinit/00001.png
Binary file modified tests_zemu/snapshots/fl-txinit/00004.png
Binary file modified tests_zemu/snapshots/fl-txinit/00005.png
Binary file modified tests_zemu/snapshots/s-1-tr-in-1-spend-2-sh-out/00020.png
Binary file modified tests_zemu/snapshots/s-1-tr-in-1-tr-out-1-spend-2-sh-out/00023.png
Binary file modified tests_zemu/snapshots/s-1-tr-out-1-spend-2-sh-out/00020.png
Binary file modified tests_zemu/snapshots/s-2-spend-2-out/00021.png
Binary file modified tests_zemu/snapshots/s-2-tr-in-2-tr-out/00012.png
Binary file modified tests_zemu/snapshots/s-builder-addr-diff-to-inittx-addr/00023.png
Binary file modified tests_zemu/snapshots/s-ext-more-sigs-than-needed-for-tx/00023.png
Binary file modified tests_zemu/snapshots/s-ext-output-without-ext-spend-data/00020.png
Binary file modified tests_zemu/snapshots/s-ext-sig-without-checkandsign/00020.png
Binary file modified tests_zemu/snapshots/s-mainmenu/00004.png
Binary file modified tests_zemu/snapshots/s-mainmenu/00010.png
Binary file modified tests_zemu/snapshots/s-not-using-ledger-rnd-for-tx/00023.png
Binary file modified tests_zemu/snapshots/s-txinit/00021.png
Binary file modified tests_zemu/snapshots/sp-1-tr-in-1-spend-2-sh-out/00017.png
Binary file modified tests_zemu/snapshots/sp-1-tr-out-1-spend-2-sh-out/00017.png
Binary file modified tests_zemu/snapshots/sp-2-spend-2-out/00018.png
Binary file modified tests_zemu/snapshots/sp-2-tr-in-2-tr-out/00009.png
Binary file modified tests_zemu/snapshots/sp-builder-addr-diff-to-inittx-addr/00019.png
Binary file modified tests_zemu/snapshots/sp-ext-more-sigs-than-needed-for-tx/00019.png
Binary file modified tests_zemu/snapshots/sp-ext-sig-without-checkandsign/00017.png
Binary file modified tests_zemu/snapshots/sp-mainmenu/00004.png
Binary file modified tests_zemu/snapshots/sp-mainmenu/00010.png
Binary file modified tests_zemu/snapshots/sp-not-using-ledger-rnd-for-tx/00019.png
Binary file modified tests_zemu/snapshots/sp-txinit/00018.png
Binary file modified tests_zemu/snapshots/st-1-tr-in-1-spend-2-sh-out/00004.png
Binary file modified tests_zemu/snapshots/st-1-tr-in-1-tr-out-1-spend-2-sh-out/00005.png
Binary file modified tests_zemu/snapshots/st-1-tr-out-1-spend-2-sh-out/00004.png
Binary file modified tests_zemu/snapshots/st-2-spend-2-out/00000.png
Binary file modified tests_zemu/snapshots/st-2-spend-2-out/00001.png
Binary file modified tests_zemu/snapshots/st-2-spend-2-out/00002.png
Binary file modified tests_zemu/snapshots/st-2-spend-2-out/00003.png
Binary file modified tests_zemu/snapshots/st-2-spend-2-out/00004.png
Binary file modified tests_zemu/snapshots/st-2-spend-2-out/00005.png
Binary file modified tests_zemu/snapshots/st-2-tr-in-2-tr-out/00002.png
Binary file modified tests_zemu/snapshots/st-builder-addr-diff-to-inittx-addr/00005.png
Binary file modified tests_zemu/snapshots/st-ext-more-sigs-than-needed-for-tx/00005.png
Binary file modified tests_zemu/snapshots/st-ext-output-without-ext-spend-data/00005.png
Binary file modified tests_zemu/snapshots/st-ext-sig-without-checkandsign/00000.png
Binary file modified tests_zemu/snapshots/st-ext-sig-without-checkandsign/00001.png
Binary file modified tests_zemu/snapshots/st-ext-sig-without-checkandsign/00002.png
Binary file modified tests_zemu/snapshots/st-ext-sig-without-checkandsign/00003.png
Binary file modified tests_zemu/snapshots/st-ext-sig-without-checkandsign/00004.png
Binary file modified tests_zemu/snapshots/st-ext-sig-without-checkandsign/00005.png
Binary file modified tests_zemu/snapshots/st-get-fvk-expert/00002.png
Binary file modified tests_zemu/snapshots/st-get-fvk/00002.png
Binary file modified tests_zemu/snapshots/st-get-ivk-expert/00002.png
Binary file modified tests_zemu/snapshots/st-get-ivk/00002.png
Binary file modified tests_zemu/snapshots/st-get-ovk-expert/00002.png
Binary file modified tests_zemu/snapshots/st-get-ovk/00002.png
Binary file modified tests_zemu/snapshots/st-mainmenu/00001.png
Binary file modified tests_zemu/snapshots/st-mainmenu/00002.png
Binary file modified tests_zemu/snapshots/st-mainmenu/00003.png
Binary file modified tests_zemu/snapshots/st-mainmenu/00004.png
Binary file modified tests_zemu/snapshots/st-not-using-ledger-rnd-for-tx/00000.png
Binary file modified tests_zemu/snapshots/st-not-using-ledger-rnd-for-tx/00001.png
Binary file modified tests_zemu/snapshots/st-not-using-ledger-rnd-for-tx/00002.png
Binary file modified tests_zemu/snapshots/st-not-using-ledger-rnd-for-tx/00003.png
Binary file modified tests_zemu/snapshots/st-not-using-ledger-rnd-for-tx/00004.png
Binary file modified tests_zemu/snapshots/st-not-using-ledger-rnd-for-tx/00005.png
Binary file modified tests_zemu/snapshots/st-show_address_shielded/00001.png
Binary file modified tests_zemu/snapshots/st-show_address_shielded_with_div/00001.png
Binary file modified tests_zemu/snapshots/st-show_address_unshielded/00001.png
Binary file modified tests_zemu/snapshots/st-show_nullifier-0x1-expert/00002.png
Binary file modified tests_zemu/snapshots/st-show_nullifier-0x1/00002.png
Binary file modified tests_zemu/snapshots/st-show_nullifier-0xFF-expert/00002.png
Binary file modified tests_zemu/snapshots/st-show_nullifier-0xFF/00002.png
Binary file modified tests_zemu/snapshots/st-txinit/00000.png
Binary file modified tests_zemu/snapshots/st-txinit/00001.png
Binary file modified tests_zemu/snapshots/st-txinit/00002.png
Binary file modified tests_zemu/snapshots/st-txinit/00003.png
Binary file modified tests_zemu/snapshots/st-txinit/00004.png
Binary file modified tests_zemu/snapshots/st-txinit/00005.png
Binary file modified tests_zemu/snapshots/x-1-tr-in-1-spend-2-sh-out/00017.png
Binary file modified tests_zemu/snapshots/x-1-tr-in-1-tr-out-1-spend-2-sh-out/00019.png
Binary file modified tests_zemu/snapshots/x-1-tr-out-1-spend-2-sh-out/00017.png
Binary file modified tests_zemu/snapshots/x-2-spend-2-out/00018.png
Binary file modified tests_zemu/snapshots/x-2-tr-in-2-tr-out/00009.png
Binary file modified tests_zemu/snapshots/x-builder-addr-diff-to-inittx-addr/00019.png
Binary file modified tests_zemu/snapshots/x-ext-more-sigs-than-needed-for-tx/00019.png
Binary file modified tests_zemu/snapshots/x-ext-output-without-ext-spend-data/00017.png
Binary file modified tests_zemu/snapshots/x-ext-sig-without-checkandsign/00017.png
Binary file modified tests_zemu/snapshots/x-mainmenu/00004.png
Binary file modified tests_zemu/snapshots/x-mainmenu/00010.png
Binary file modified tests_zemu/snapshots/x-not-using-ledger-rnd-for-tx/00019.png
Binary file modified tests_zemu/snapshots/x-txinit/00018.png

0 comments on commit 8feb7fe

Please sign in to comment.