Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Todo list: Montage Review #4036

Open
connortechnology opened this issue May 23, 2024 · 17 comments · May be fixed by #4140
Open

Feature Todo list: Montage Review #4036

connortechnology opened this issue May 23, 2024 · 17 comments · May be fixed by #4140

Comments

@connortechnology
Copy link
Member

Montage Review is fairly broken in it's design. It currently constantly grab images one at a time and writes them to a canvas. It seems that this cannot handle an mjpeg stream.

The reason for the canvas is to be able to write text and the +/- buttons onto it. I think we should replace it with the new layout from montage.

OR

We copy over the history timeline logic to montage and scrap review.

@IgorA100
Copy link
Contributor

IgorA100 commented May 23, 2024

Aaaaaaa...... Montage Review...... This is a “terrible dream” :)))
Montage page is a lot of work.
I must rest.

@IgorA100
Copy link
Contributor

canvas is to be able to write text

I don’t quite understand what kind of text you are writing about?

@connortechnology
Copy link
Member Author

If it can't load event data it writes "No data"over the image. Really not needed. Can be done other ways.

@IgorA100
Copy link
Contributor

Ok.

@IgorA100
Copy link
Contributor

Is Live mode required?
In essence, this is a duplication of the Montage page, but with FPS = 1.
FPS = 1-5 - this would be very good for a narrow network channel on both Montage and Montage Review

@connortechnology
Copy link
Member Author

No it is not. I would really like to merge these two views. At the moment montage is much better.

I will be committing a branch tomorrow that adds an fps limiter to montage.

@IgorA100
Copy link
Contributor

Why not make a single page for live viewing and for viewing recordings?
For example, you can make such a page based on Montage page.

@IgorA100
Copy link
Contributor

IgorA100 commented Jun 19, 2024

@connortechnology
What is this button on Montage page for and does it work?
5

When you press it, the camera control panel appears, but there is no image from the camera.
6

@connortechnology
Copy link
Member Author

It is a leftover from the past. In the past everything was popups. It is the PTZ ui for cameras that support it. It doesn't have it's own image feed, it would control the image feed in the montage. Problem is that every camera can have different controls. So how it looks is camera dependent. I'm not sure how useful it is, and since it is broken and no one has complained... perhaps it could just go away.

@connortechnology
Copy link
Member Author

I think maybe you deleted the question about ZM_OPT_CONTROL. For js land, all is provided by web/skins/classic/js/skin.js.php. All but a few config variables are exposed there.

For php it is in web/includes/config.php.in (which becomes config.php).

@IgorA100
Copy link
Contributor

It is a leftover from the past.
...... perhaps it could just go away.

Got it, I’ll leave it “as is” for now, I won’t delete it. I thought that maybe something was broken on me. I also don’t see the point in this page if the camera can be controlled on the Watch page.

@connortechnology
Copy link
Member Author

The only point would be to do so while watching multiple feeds. Which is a valid use case, maybe you have multiple cameras from different angles watch a scene...

@IgorA100
Copy link
Contributor

The only point

Yes, it’s possible, but now I definitely won’t do it, because... a lot of work on partially converting the Montage page to Ajax and integrating it with Montage Review.

@IgorA100
Copy link
Contributor

I think maybe you deleted the question about ZM_OPT_CONTROL.

Yes, I deleted the message because... I have access to the ZM_OPT_CONTROL constant in my PHP code, but I still don’t understand where it is defined.

For php it is in web/includes/config.php.in (which becomes config.php).

The fact of the matter is that there is no ZM_OPT_CONTROL constant in config.php
It probably comes from SQL somewhere and must be defined in PHP somewhere.

@connortechnology
Copy link
Member Author

It is in the database.
config.php loads /etc/zm.conf to find out where the database is. Then loads the contents of the Config table.

@connortechnology
Copy link
Member Author

database config entries are defined in scripts/ZoneMinder/lib/ZoneMinder/ConfigData.pm.in, but for dev purposes you can just add it to a file in /etc/zm/conf.d/newconfig.conf

@IgorA100
Copy link
Contributor

Thanks, I got it.

@IgorA100 IgorA100 linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants