-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Viewing recorded events on Montage page #4140
base: master
Are you sure you want to change the base?
Conversation
The class file is located at the path: "/www/skins/NameSkins/views/class" The class file name should be: "montage_class.php" - for Montage page "watch_class.php" - for Watch page etc.
…le click on TimeLine on mobile devices (skin.js)
…he image on (skin.css)
I have concerns about this vis.js based stuff... mainly about it not being maintained. Are we sure this is the right library to go with? I've done timelines with apexcharts and chart.js. |
|
@connortechnology |
There's no point in paying attention to ESLint right now. |
There is something wrong... live works but in recording doesn't. The video goes away leaving just the timeline. |
There are no errors in the console?
These are small things... I'll add 5px
Not quite so....
"pause" - pauses playback (sends the CMD_PAUSE command). When you click "Play" - playback starts immediately without delay
purple - this is essentially the event frame. TimeLine scaling - "Shift + mouse wheel. I did not create buttons. I don't know if they are needed? "Ctrl" + double click on TimeLine - will create a time marker at the click location. It can be moved. When you press the "Play" button, playback will start from the place where the marker was. When you pause, a marker will also appear that can be moved. |
This is all up for discussion. I didn't really choose the colors on TimeLine, I used relatively contrasting colors. I'm most interested in the fundamental question of this PR. Will you like this PR or not. |
Very strange. |
Done 873d715 |
& get the 1st frame of the event if there are no files with IMG for the event
Instead of the inscription "No Event" (when the event is not played), I should probably write something else, for example "Stop", or not write anything at all.... |
No recording for this time |
Is this text not very long? |
…nstead of "No Event" (montage.js)
Yeah it works now |
Phew... |
& Instead of 'No Event' display 'No recording for this time'
@connortechnology |
Heh, my hope is almost gone :( |
@connortechnology |
My life is not going well. I don't even have the energy to look at it. |
Oh, sorry. |
This PR should be considered as an
AlphaBeta version for now. There aremanycomments here, including some NOT in English. There is also debugging information.It's easier for me to finish this project.
Naturally, I will gradually put the code in order.
Isaac, I hope you don't mind?
Known issues at the moment:
- Double click does not work on mobile devices
-
If the last recorded event is recorded incorrectly, then nothing will be displayed. That is, you need to add an analysis- "command:CMD_MAXFPS" does not work for playable events
- "If you pause Event, the static image disappears after a while. The same thing happens on the Event page. Probably, you need to send some command (except CMD_QUERY) with some frequency.
Closed #4036