Sub-optimal loops

[litzinger]

You're doing a lot of extra queries in the loop you have setup. It looks like the filter method may support an 'IN' operator as the 3rd argument.

$members = ee('Model')->get('Member')->all();
$memberIds = [];

// Do something here, a loop maybe, to get all the member ids.

$data = "";
$count = 0;
$entries = ee('Model')->get('ChannelEntry')
    ->filter('channel_id', $channel)
    ->filter('author_id', $memberIds, 'IN')
    ->all();

// Would count($entries) work here instead?
foreach ($entries as $entry) {
    $count++;
}
if ($count != 0) {
    $data["mem_id"] = $member->member_id;
    $data["mem_name"] = $member->screen_name;
    $data["counted"] = $count;
    $vars[] = $data;
}

[litzinger]

You're also defining $data as a string, then later using it as an array.

$data = [];