diff --git a/jolt-core/src/subprotocols/grand_product_quarks.rs b/jolt-core/src/subprotocols/grand_product_quarks.rs index adaee3837..62057c917 100644 --- a/jolt-core/src/subprotocols/grand_product_quarks.rs +++ b/jolt-core/src/subprotocols/grand_product_quarks.rs @@ -207,7 +207,7 @@ where // For polynomials of size less than 16 we just use the GKR grand product let (quark_proof, mut random, mut claim) = if grand_product.quark_poly().is_some() { // When doing the quark hybrid proof, we first prove the grand product of a layer of a polynomial which is N layers deep in the tree - // of a standard layered sumcheck grand product, then we use the sumcheck layers to prove via gkr layers that the random point opened + // of a standard layered sumcheck grand product, then we use the sumcheck layers to prove via GKR layers that the random point opened // by the quark proof is in fact the folded result of the base layer. let (quark, random, quark_claim) = QuarkGrandProductProof::::prove( @@ -315,8 +315,8 @@ where let v_length = v.len(); let v_variables = v_length.log_2(); - // Compute f(1, x), f(x, 0), and f(x, 1) from v(x) let v_polynomial = DensePolynomial::::new_padded(v.to_vec()); + // Compute f(1, x), f(x, 0), and f(x, 1) from v(x) let (f_1x, f_x0, f_x1) = v_into_f::(&v_polynomial); let g_polynomial = f_1x.clone(); diff --git a/jolt-core/src/subprotocols/mod.rs b/jolt-core/src/subprotocols/mod.rs index 7df6213b4..1904bec9e 100644 --- a/jolt-core/src/subprotocols/mod.rs +++ b/jolt-core/src/subprotocols/mod.rs @@ -15,7 +15,8 @@ pub enum QuarkHybridLayerDepth { } impl QuarkHybridLayerDepth { - // The depth in the product tree of the GKR grand product at which the hybrid scheme will switch to using quarks grand product proofs + // The depth in the product tree of the grand product at which the + // hybrid implementation will switch to using quarks grand product proofs pub fn get_crossover_depth(&self) -> usize { match self { QuarkHybridLayerDepth::Min => 0, // Always use quarks diff --git a/jolt-core/src/subprotocols/sparse_grand_product.rs b/jolt-core/src/subprotocols/sparse_grand_product.rs index 46e746541..1e192b51d 100644 --- a/jolt-core/src/subprotocols/sparse_grand_product.rs +++ b/jolt-core/src/subprotocols/sparse_grand_product.rs @@ -386,8 +386,8 @@ impl BatchedCubicSumcheck>, @@ -1062,7 +1062,7 @@ where } /// Verifies the given grand product proof. - #[tracing::instrument(skip_all, name = "BatchedGrandProduct::verify_grand_product")] + #[tracing::instrument(skip_all, name = "ToggledBatchedGrandProduct::verify_grand_product")] fn verify_grand_product( proof: &BatchedGrandProductProof, claimed_outputs: &[F],