Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cluster when provisioning isn't fully done #5

Open
mwienk opened this issue Apr 11, 2023 · 1 comment
Open

Invalid cluster when provisioning isn't fully done #5

mwienk opened this issue Apr 11, 2023 · 1 comment

Comments

@mwienk
Copy link

mwienk commented Apr 11, 2023

The synchronizer synchronizes too early for my use case. Crossplane already creates a secret that contains the kubeconfig, but the caCert isn't correct yet. Crossplane updates it after the cluster is fully provisioned, but by that time the argocd cluster is already created with an invalid configuration. My current fix is to delete the argocd cluster secret and regenerate one by modifying a label on the kubeconfig secret, but I think the synchronizer should:

  1. Check if there is enough information in the secret, and only trigger when it finds enough information.
  2. Update the cluster when the original kubeconfig file gets updated, for instance when the caData is changed.

I would love to create a PR for this, but I'm not sure where to start as I have no experience with Golang/k8s operators development (yet).

@a1tan
Copy link
Owner

a1tan commented Oct 14, 2023

Sorry @mwienk, I haven't noticed this issue somehow. If it is still needed I can find some time to fix it. Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants