-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl needed more event #178
Comments
If two DNS requests arrive in quick succession, we normally rely on
curl's CURLMOPT_PIPELINING
option to multiplex them over the one TCP connection. This is what happens
in HTTP/2 and HTTP/3. If the server (or proxy) they're talking to is using
HTTP/1, then multiplexing is not supported so if a bunch of requests come
in together, then we either queue them up or create multiple connections --
one per request.
I imagine this must be what is going on although I'm not sure how that
error occurs. There might be an off by one error somewhere. Do you have any
more details on curl versions, etc I can see?
CURLMOPT_MAX_TOTAL_CONNECTIONS should be set to MAX_TOTAL_CONNECTIONS when
we setup curl and that error implies that curl is sending us more than that
or we've somehow gotten out of sync.
…On Tue, 10 Dec 2024 at 04:32, Stan Grishin ***@***.***> wrote:
Hey @aarond10 <https://github.com/aarond10>, I've never seen it before
but someone reported seeing a message from
https://github.com/aarond10/https_dns_proxy/blob/master/src/https_client.c#L601-L604
in their logs.
Can you explain in laymans terms why/when it happens? Is it something that
needs to be changed in curl when it's built?
Also, would you like a PR which fixes the message so it's more
understandable?
—
Reply to this email directly, view it on GitHub
<#178>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABTOXXJFJ4QUCHMBDWSG6T2EXH4RAVCNFSM6AAAAABTJK54JOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZDONZZGEYTOMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for your prompt reply @aarond10, here's the link with the OpenWrt issue with curl version and for resolver url they are using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @aarond10, I've never seen it before but someone reported seeing a message from https://github.com/aarond10/https_dns_proxy/blob/master/src/https_client.c#L601-L604 in their logs.
Can you explain in laymans terms why/when it happens? Is it something that needs to be changed in curl when it's built?
Also, would you like a PR which fixes the message so it's more understandable?
The text was updated successfully, but these errors were encountered: