add image in markdown format #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| const newImages = [...uploadedImages, { name, url }]; | ||
| setUploadedImages(newImages); | ||
| localStorage.setItem(`uploadedImages_${questionIdInFocus}`, JSON.stringify(newImages)); |
There was a problem hiding this comment.
why do we need to set this in localStorage?
| @@ -25,6 +27,17 @@ function AnswerSettings() { | |||
| option.answerSettings.renderElement === answerSettings.renderElement | |||
| ); | |||
|
|
|||
| const [uploadedImages, setUploadedImages] = useState<Array<{name: string, url: string}>>(() => { | |||
There was a problem hiding this comment.
why do we need this state when we are already using the editQuestion context?
keraliss
force-pushed
the
upload_image_button
branch
from
545c248
to
dcdfb60
Compare
| @@ -138,7 +138,7 @@ const UploadImage: React.FC<Props> = ({ onImageUpload }) => { | |||
| shape="circle" | |||
| style={{ fontSize: '16px', marginRight: '10px' }} | |||
| > | |||
| 📁 | |||
| <FolderOutlined /> | |||
There was a problem hiding this comment.
can we have this to <PictureOutlined /> ?
| formData.append("image", file); | ||
|
|
||
| const response = await fetch( | ||
| "https://api.imgbb.com/1/upload?key=47b2691c6dca3f52bf6f70029396682d", |
| question[4], | ||
| JSON.stringify({ | ||
| ...answerSettings, | ||
| imageUrl: imageMarkdown, |
There was a problem hiding this comment.
we don't need this anymore? since we're already adding the image markdown in newDisplay on question[3] ?
| ? `${currentDisplay}\n\n${imageMarkdown}` | ||
| : imageMarkdown; | ||
|
|
||
| const field: Field = [ |
There was a problem hiding this comment.
we could also have done
field = question and field[3] = newDisplay but it's fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.