Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator, to run in CI, that ensures errors.json only contains codes below 100000 #161

Open
QuintinWillison opened this issue Jul 22, 2022 · 2 comments
Open

Add validator, to run in CI, that ensures errors.json only contains codes below 100000 #161

QuintinWillison opened this issue Jul 22, 2022 · 2 comments

Comments

@QuintinWillison
Copy link
Contributor

This is because we've decided that codes from 100000 are to be canonically defined outside the scope of this repository. They are reserved for use by specific Ably projects and ecosystems.
@QuintinWillison
Copy link
Contributor Author

Follows on from #162.

@mattheworiordan mattheworiordan mentioned this issue Nov 25, 2024
Open
@mattheworiordan
Copy link
Member

FYI. We now use error codes >= 100000, see https://github.com/ably/ably-common/tree/main/protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @QuintinWillison