Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickJS and JavaScriptCore behave inconsistently. #143

Open
widealpha opened this issue Dec 6, 2023 · 2 comments
Open

QuickJS and JavaScriptCore behave inconsistently. #143

widealpha opened this issue Dec 6, 2023 · 2 comments

Comments

@widealpha
Copy link

Is there a way to remove the JSON.stringify method from handle_promise.dart, specifically from JSON.stringify(FLUTTER_NATIVEJS_PENDING_PROMISES[$idxPromise].getValue())(line 153-155)?
When I return a JSON string from the native side, using JavaScriptCore results in double-serialization, causing inconsistency with QuickJs return values. Is there a specific reason for this design?
image

version: flutter_js: ^0.8.0

@abner
Copy link
Owner

abner commented Jun 7, 2024

Could be fixed. Are you able to submit a PR? I would review it.

@widealpha
Copy link
Author

widealpha commented Jun 7, 2024

I have submitted a PR #152. I think this is a break change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants