Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockpoold eats up all memory when trying to connect to pocket in readebble #51

Open
BjoernRuberg opened this issue Oct 15, 2016 · 4 comments

Comments

@BjoernRuberg
Copy link

Readebble is a pebble app for displaying rss feeds. It has support for reading articles from the pebble webservice.
When I try to login to pocket (which is implemented via oauth on the settings webpage), the rockpool app freezes after having inserted the correct credentials.
Via top I can see rockpoold eating up all memory. Phone freezes until the process is killed.

@rufferson
Copy link
Contributor

Ok, so you're inserting it in watchapp settings page and committing the settings, it closes the settings window falling back to apps list. and at this point it rockpool app freezes and rockpoold service starts eating memory?
Perhaps javascript attempts to download way too much without anyone pulling a rein. need to look if it's the case and to figure the rein.

@BjoernRuberg
Copy link
Author

Almost. But I do not get back to the apps list after inserting the credentials. I get a spinner window or a blank page (not completly sure at this moment). You would expect at least a confirmation page that the credentials did their job before falling back to the apps list. But both does not happen.

@rufferson
Copy link
Contributor

Ok I'm looking now at readable sources, when you authorize pocket with oauth it sends pebble/close event to store the configuration (user/authtoken). At this moment it should send a notification to watches:
'Hi ' + Readebble.pocket.username + '! You are now logged in to Pocket!\n\nHold the select button to add a story to your Pocket.'
Do you receive this message? Or it getting stuck even before that? I see nothing what can stop it before - it merely stores credentials into JS persistent storage.
There's only one suspicious thing - when I authorized it for the first time (selected firefox oauth provider) - it didn't return me just credentials but rather entire pocket profile (html page). So if pebble will try to serialize that as json blob... it may do nasty things. But again - it just forwarded me to that profile page, didn't send close message. Or at least I didn't capture that event.
On second attempt (when browser already cached oauth creds) it returned proper short json message with pebble/close message.

@BjoernRuberg
Copy link
Author

I definetly never got a message on my watch. Currently I cannot repeat the process. Because in readebble settings I always get the page "You have been sucessfully logged in" when I press on the pocket button in the settings of readable.
Afterwards I cannot do anything anymore, have to close rockpool. I have not found a place where this pocket information might be stored on the phone. In the js-storage directory of rockpool I see nothing.

I have another heavy bug with all settings pages of apps in rockpool. I report that now. Maybe it this is all a symptom of another problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants