-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide TS typedefs #43
Comments
Yeah, it'll be so helpful. So far, only this JS dependencies have no typedefs in my project. And now I'm forced to spend hours to realize how to provide minimal type definitions to make TS compile again. Maybe I'm missing some easy ways. If so - it will be convenient to have small section in documentation dedicated to TypeScript users. I'm constantly trying to propagate Elixir/Phoenix to my colleagues and such time wasting points makes evangelism harder. |
I am also stuck with typescript errors. Any thoughts about how to get this working with Typescript or any references? |
Quick fix:
It will consider X as any. |
I started to integrate subscriptions in a React/TypeScript app and besides the needed packages I installed the types like this:
|
@eisnstein Those typedefs are flawed. In particular, |
I'm starting the engines again, the idea is to move forward with the following:
Once we get here, it will be easier for people to contribute (TS vs Flow, and PR merged => released). I will close this issue once we have finished the migration to TS, thanks for the patience. |
Asking not out of impatience (really, open source work is hard and I'm very grateful) but for timing – should someone implementing today wait on this (and be okay without types) vs using a fork with types right now? |
I'm just looking into setting up semantic release for a forked version we have of this repo and was also thinking it might make sense to migrate to typescript. Using semantic release alongside Renovate should make it pretty low maintenance to keep it up to date. @mgtitimoli Would you be open to a contribution to set this up? |
@joshsmith The repo is still a bit messy from me trying to get the release process working but in this fork I've setup Semantic Release and NX so that new release are created for every PR. |
Hi,
It would be convenient for TS users have type definitions shipped with the packages
The text was updated successfully, but these errors were encountered: