Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch 53 Update - Unlink connection issues #160

Open
meecasso opened this issue Feb 6, 2019 · 8 comments
Open

Sketch 53 Update - Unlink connection issues #160

meecasso opened this issue Feb 6, 2019 · 8 comments

Comments

@meecasso
Copy link

meecasso commented Feb 6, 2019

The ability to unlink/remove a connection seems to be broken with the latest update to Sketch (53)for some elements (not all)

On certain items (this one is a vector):

Shortcut doesn't remove connection
Menu doesn't remove connection
Delete asset and add same asset, connection reappears
Delete connections from connection folder, add asset back in, connections reappear

@abynim
Copy link
Owner

abynim commented Feb 7, 2019

@meecasso Thank for reporting, but I cant reproduce this 🤔 Can you please check Console.app if it shows any errors when you run the command from the menu? Could also be specific to your settings, so please add a screenshot of your UserFlows settings so I can try to reproduce it here.

@rabbit-roger
Copy link

I have the same problem. All links are down. I reinstalled the plugin and reset the settings to default and nothing helps. When I show/redraw flow, I stop seeing artboards. They are just white:

image

When I tried to generate a diagram, I got this:

image

Previously, it looked like this:

image

@abynim
Copy link
Owner

abynim commented Feb 10, 2019

Still can't seem to reproduce this, even with default settings. Does it only happen with this specific page/document or can you successfully reproduce it even in a new document with a simple flow? Could you also please check Console.app if it shows any errors from Sketch when you run the command? Thanks @Mihkach

@rabbit-roger
Copy link

@abynim I checked all my files and only in two of them I see this problem. It is very strange.

@abynim
Copy link
Owner

abynim commented Feb 12, 2019

Wow, so weird. Would it be possible to share any one of those documents?

@mattbaldo100
Copy link

Hey - using the plugin on Sketch v54.1

I had the same issue on what was a massive project file (artboards, not file size) which could have been a contributing factor.

Testing the 'user flows' function in your plugin seems to align to all existing links - so the connections are still valid - but they render in a completely different position to where they should be.

As an emergency work-around I

  • downloaded an older version of sketch (< v52)
  • opened up the project file (where some links had rendered correctly, but not all)
  • refreshed all links
  • saved the file
  • turned off the plugin
  • reopened the file (plugin disabled) to continue working

I know this may not solve the problem, but acts as a useful work around to retain existing links. Creating new links however is an issue, as the minute I turned the plugin back on and refreshed, I was back to square one.

@abynim
Copy link
Owner

abynim commented Apr 25, 2019

@mattbaldo100 can you please try the following steps:

  • save a copy of your document
  • then open Console.app
  • then enable the plugin and let it fail
  • check Console.app if any errors are being logged
  • post the errors back here

Thanks 👍

@mattbaldo100
Copy link

Hey -

(I'm not a developer so I'm sorry if this is incorrect / useless) - but this is what popped up in the console: (after I'd used the keyboard shortcut to 'Show or redraw connections'

Fault:
CGImageSourceCreateWithData:3054: *** ERROR: CGImageSourceCreateWithData: data is nil

Error:
Passed filters are not valid. Unable to build predicate

Hope this helps!

Cheers

Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants