Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install from repo breaks backward compatibility #14

Open
andylytical opened this issue Oct 25, 2024 · 1 comment
Open

Install from repo breaks backward compatibility #14

andylytical opened this issue Oct 25, 2024 · 1 comment

Comments

@andylytical
Copy link

Branch CTT-221/aloftus/install_from_repo creates a new install method directly from the git repo as a normal user. This provides a very easy and fast (~5-10 mins) install and configuration to get up and running quickly.

As currently implemented, it changes key files that make it incompatible by anyone that already installed the tool from an older version and also breaks installing via previous methods. Before merge to main, this should be addressed.

Changes needed:

  • ipf/etc/ipf/init.d/ipf-WORKFLOW
    • This file is the template init script used by configure_workflow.py.
    • The "easy installer" method described above changes this file so it works when invoked by a non-root user.
    • Suggestions:
      • Make one that can be used in either case (ie: works whether invoked by root or a non-root user)
      • Find a workaround to replacing it on the fly (maybe during setup.sh). A slight inconvenience in this approach is now there are two templates to manage.

Full comparison of changes at: Compare CTT-221/aloftus/install_from_repo <- master

@andylytical
Copy link
Author

A review of the comparison shows additional breaking changes were made. Reversing these looks like:

  • RESTORE ipf/bin/ipf_configure
  • RESTORE ipf/bin/ipf_workflow
  • RESTORE ipf/etc/ipf/init.d/ipf-WORKFLOW
  • CREATE an alternate verison of ipf/etc/ipf/init.d/ipf-WORKFLOW that will be used just for Quick Install

andylytical added a commit that referenced this issue Nov 10, 2024
andylytical added a commit that referenced this issue Nov 11, 2024
andylytical added a commit that referenced this issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant