Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataInstance should extend AccessibleResource #9511

Open
driusan opened this issue Dec 12, 2024 · 0 comments
Open

DataInstance should extend AccessibleResource #9511

driusan opened this issue Dec 12, 2024 · 0 comments
Labels
Category: Refactor PR or issue that aims to improve the existing code Cleanup PR or issue introducing/requiring at least one clean-up operation Difficulty: Medium PR or issue that require a moderate effort or expertise to implement, review, or test Language: PHP PR or issue that update PHP code Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered

Comments

@driusan
Copy link
Collaborator

driusan commented Dec 12, 2024

isAccessibleBy is a method that you should be able to call on any arbitrary DataInstance object.

This was not done initially, because it extends jsonSerializeable, but in fact, since it is an interface, it can extend both interfaces to ensure that DataInstance implementations implement both.

Related to #7417 (this would allow use to share concrete instances of a DataInstance objects between provisioners and entities.)
@driusan driusan added Category: Refactor PR or issue that aims to improve the existing code Cleanup PR or issue introducing/requiring at least one clean-up operation Difficulty: Medium PR or issue that require a moderate effort or expertise to implement, review, or test Language: PHP PR or issue that update PHP code Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Refactor PR or issue that aims to improve the existing code Cleanup PR or issue introducing/requiring at least one clean-up operation Difficulty: Medium PR or issue that require a moderate effort or expertise to implement, review, or test Language: PHP PR or issue that update PHP code Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@driusan