diff --git a/.coderabbit.yaml b/.coderabbit.yaml index af1abac06..fc524c4ad 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -1,5 +1,5 @@ language: en-US -tone_instructions: '' +tone_instructions: 'Be constructive and professional. Focus on technical accuracy while maintaining a friendly tone.' early_access: true enable_free_tier: true reviews: @@ -15,8 +15,16 @@ reviews: sequence_diagrams: true changed_files_summary: true labeling_instructions: [] - path_filters: [] - path_instructions: [] + path_filters: + - 'src/**/*.cpp' + - 'include/**/*.hpp' + path_instructions: + - path: 'src/**/*.cpp' + instructions: 'Focus on performance, memory management, and RAII principles' + - path: 'include/**/*.hpp' + instructions: 'Focus on design patterns, interfaces, and encapsulation' + - path: 'test/**/*.cpp' + instructions: 'Ensure comprehensive test coverage and proper test organization' abort_on_close: true auto_review: enabled: true @@ -28,8 +36,6 @@ reviews: tools: shellcheck: enabled: true - ruff: - enabled: true markdownlint: enabled: true github-checks: @@ -43,25 +49,12 @@ reviews: enabled: true hadolint: enabled: true - swiftlint: - enabled: true - phpstan: - enabled: true - level: default - golangci-lint: - enabled: true yamllint: enabled: true gitleaks: enabled: true checkov: enabled: true - detekt: - enabled: true - eslint: - enabled: true - rubocop: - enabled: true buf: enabled: true regal: diff --git a/CMakeLists.txt b/CMakeLists.txt index 646382afb..c9dae958d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -67,6 +67,14 @@ include(CMakeDependentOption) # Set CGAL_DATA_DIR to the location of the CGAL data files set(ENV{CGAL_DATA_DIR} CMAKE_BINARY_DIR/Data) +if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "19.34") + message(FATAL_ERROR "MSVC 19.34 or higher required for C++23 support") +elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "12.2") + message(FATAL_ERROR "GCC 12.2 or higher required for C++23 support") +elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "16.0") + message(FATAL_ERROR "Clang 16.0 or higher required for C++23 support") +endif() + # Set NOMINMAX to avoid min/max macro errors on Windows in date.h #if(WIN32) # # Workaround for https://github.com/CGAL/cgal/issues/4665 and https://github.com/microsoft/vcpkg/issues/23572 diff --git a/cmake/StandardProjectSettings.cmake b/cmake/StandardProjectSettings.cmake index d17caeba3..83923a05e 100644 --- a/cmake/StandardProjectSettings.cmake +++ b/cmake/StandardProjectSettings.cmake @@ -61,4 +61,3 @@ if (MSVC) else() add_compile_options(-finput-charset=UTF-8) endif() - diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index e7a6765bf..22ef11b73 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -53,7 +53,7 @@ target_compile_features(cdt PRIVATE cxx_std_23) # spdlog::spdlog_header_only # TBB::tbb # CGAL::CGAL_Basic_viewer) -# target_compile_features(cdt-viewer PRIVATE cxx_std_20) +# target_compile_features(cdt-viewer PRIVATE cxx_std_23) #endif() # Build bistellar-flip locally, but not in CI since QT takes more than an hour to build there @@ -69,7 +69,7 @@ target_compile_features(cdt PRIVATE cxx_std_23) # spdlog::spdlog_header_only # TBB::tbb) # CGAL::CGAL_Basic_viewer) -# target_compile_features(bistellar-flip PRIVATE cxx_std_20) +# target_compile_features(bistellar-flip PRIVATE cxx_std_23) #endif() # diff --git a/src/bistellar-flip.cpp b/src/bistellar-flip.cpp index 2e7276f63..3a218f2d7 100644 --- a/src/bistellar-flip.cpp +++ b/src/bistellar-flip.cpp @@ -69,7 +69,7 @@ try manifolds::Manifold_3 const manifold{ foliated_triangulations::FoliatedTriangulation_3{dt, 0, 1} }; -// CGAL::draw(manifold.get_delaunay()); + // CGAL::draw(manifold.get_delaunay()); fmt::print("After bistellar flip.\n"); manifold.print_cells(); utilities::print_delaunay(dt);