-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a NewTransaction
function
#6
Comments
please assign this to me |
!assign @sakshipai213 |
@sakshipai213 The bot will deassign you in 30mins. If you need more time, show your progress and I can extend the time. Please feel free to text/call me at 8618950413 |
Hey @Smuzzy-waiii! The timer for the @sakshipai213 to work on the issue has finished, deassign and assign a new contributor or extend the current timer. Contact maintainer leads if inactive @DedLad @polarhive @achyuthcodes30 |
@sakshipai213 Are you still working on this? |
nope...couldnt do it..sorry |
@sakshipai213 May I deassign you then |
ok |
!deassign |
Currently all the functions of onyx take in a
*badger.Txn
as their final argument which lets the user pass in a transaction under which the graph operation should be executed. However, currently there is no way for users of Onyx to actually create a new*badger.Txn
without callinggraph.DB.NewTransaction()
, which requires theDB
field of theGraph
struct to be publicly exposed, which is not ideal.Create a function
NewTransaction
on theGraph
struct which returns a*badger.Txn
for the users to use. Note thatNewTransaction
should take in a boolean which tells it if a read-only txn or a read-write txn.Remember to create a unit test for this function!
psst, remember to update the usage guide in the README too 👀
The text was updated successfully, but these errors were encountered: