Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a NewTransaction function #6

Open
Smuzzy-waiii opened this issue Oct 15, 2024 · 9 comments
Open

Create a NewTransaction function #6

Smuzzy-waiii opened this issue Oct 15, 2024 · 9 comments
Labels
Bounty: 50 gain 50 points enhancement New feature or request good first issue Good for newcomers

Comments

@Smuzzy-waiii
Copy link

Smuzzy-waiii commented Oct 15, 2024

Currently all the functions of onyx take in a *badger.Txn as their final argument which lets the user pass in a transaction under which the graph operation should be executed. However, currently there is no way for users of Onyx to actually create a new *badger.Txn without calling graph.DB.NewTransaction(), which requires the DB field of the Graph struct to be publicly exposed, which is not ideal.

Create a function NewTransaction on the Graph struct which returns a *badger.Txn for the users to use. Note that NewTransaction should take in a boolean which tells it if a read-only txn or a read-write txn.

Remember to create a unit test for this function!

psst, remember to update the usage guide in the README too 👀

@Smuzzy-waiii Smuzzy-waiii added enhancement New feature or request good first issue Good for newcomers Bounty: 50 gain 50 points labels Oct 15, 2024
@sakshipai213
Copy link

please assign this to me

@Smuzzy-waiii
Copy link
Author

!assign @sakshipai213

@Smuzzy-waiii
Copy link
Author

@sakshipai213 The bot will deassign you in 30mins. If you need more time, show your progress and I can extend the time. Please feel free to text/call me at 8618950413

@bunsamosa-bot
Copy link

bunsamosa-bot bot commented Oct 18, 2024

Hey @Smuzzy-waiii! The timer for the @sakshipai213 to work on the issue has finished, deassign and assign a new contributor or extend the current timer. Contact maintainer leads if inactive @DedLad @polarhive @achyuthcodes30

@Smuzzy-waiii
Copy link
Author

@sakshipai213 Are you still working on this?

@sakshipai213
Copy link

nope...couldnt do it..sorry

@Smuzzy-waiii
Copy link
Author

@sakshipai213 May I deassign you then

@sakshipai213
Copy link

ok

@Smuzzy-waiii
Copy link
Author

!deassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: 50 gain 50 points enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants