-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various fintan things #72
Draft
leogott
wants to merge
18
commits into
acoli-repo:fintan-support
Choose a base branch
from
leogott:fintan-feature-formatter
base: fintan-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
various fintan things #72
leogott
wants to merge
18
commits into
acoli-repo:fintan-support
from
leogott:fintan-feature-formatter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogott
force-pushed
the
fintan-feature-formatter
branch
from
January 31, 2022 12:25
4cc02f3
to
767ba1e
Compare
Remove duplicate fintan-core dependency Bump commons-cli from 1.4 to 1.5.0 Bump Junit5 jupiter from 5.7.0 to 5.8.2 Remove dependencyManagement Section (not effective)
Bump fasterxml jackson-databind from 2.12.3 to 2.13.1 Bump apache commons-lang3 from 3.4 to 3.12.0
leogott
force-pushed
the
fintan-feature-formatter
branch
from
February 1, 2022 18:09
767ba1e
to
d24f9dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some (quite a bit) less polished changes building onto #71 .
Add JaCoCo maven plugin, which runs in the test phase of the build and provides a code-coverage report
Refactor ANSI control characters into their own utility class
Formatter extends (fintan) StreamWriter
Updater (badly) extends RDFUpdater
further small-ish refactoring