Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a configuration block instead of defining "namespace" and "config_file" etc in the module itself #11

Open
acook opened this issue Apr 9, 2013 · 0 comments · May be fixed by #41
Open

Use a configuration block instead of defining "namespace" and "config_file" etc in the module itself #11

acook opened this issue Apr 9, 2013 · 0 comments · May be fixed by #41
Assignees
@acook
Labels
enhancement

Comments

@acook
Copy link
Owner

acook commented Apr 9, 2013

Right now namespace and config_file and soon config_env are defined on the module itself, while its only a handful of methods, it might be cleaner to do this in a configuration block:

module ExampleConfig
  extend ConfigModule
  config_module do
    file 'config/example.yml'
    env :example
    namespace config_module.env
  end
end

or maybe...

module ExampleConfig
  extend ConfigModule.setup do
    file 'config/example.yml'
    env :example
    namespace config_module.env
  end
end

This would also allow for lazy evaluation of methods that will be defined by the user on the module itself.
@ghost ghost assigned acook Apr 9, 2013
This was referenced Oct 3, 2015
Closed
Merged
@acook acook linked a pull request Jun 19, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acook acook

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ConfigModule 2.0 acook/config_module
1 participant
@acook