Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up: when clauses may be broken with the next VS Code release #227

Open
ulugbekna opened this issue Mar 6, 2023 · 0 comments
Open

Comments

@ulugbekna
Copy link

Hi 👋

VS Code team engineer here 🙂

We're reworking how we parse when clause contexts and noticed that we may break some of the when clauses used in your extension. You can read more in this issue, which describes upcoming changes: new features, breakages, and migration advice (latest VS Code Insiders now has a linter for when clauses and runs the new parser as default). You can also leave us feedback there.

Here are the clauses that will be broken:

current: foo =~ /file//
reason: the slash within the regex is unescaped
fixed: foo =~ /file\\//

Thanks for a great extension, it's very popular!

Best,
Ulugbek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant