Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger doesn't seem to start with 2.0.10, but works with 2.0.9 #298

Open
fstenstrom opened this issue Jul 27, 2024 · 7 comments
Open

Debugger doesn't seem to start with 2.0.10, but works with 2.0.9 #298

fstenstrom opened this issue Jul 27, 2024 · 7 comments
Labels

Comments

@fstenstrom
Copy link

The debugger doesn't seem to start with 2.0.10, but it works with 2.0.9.

For 2.0.10, nothing happens when starting a debug session. VS Code just shows that "something is loading" for about a second, and then nothing more. I didn't manage to find any logs.

I'm using WSL with Devcontainer and Lua 5.4. Attached zip with setup: proj.zip

@actboy168 actboy168 added the bug label Jul 31, 2024
@dev0x13
Copy link

dev0x13 commented Aug 5, 2024

I confirm, that happens on my setup as well (VSCode 1.92.0, Ubuntu 24.04, Lua 5.4).

@fikin
Copy link

fikin commented Aug 13, 2024

and i can confirm same (debian bookworm, vscode 1.91.1, lua53)

@yuanyan3060
Copy link

and i can confirm same (arch, vscode 1.92.2, luajit)

@musteresel
Copy link

Can confirm with VSCode:

Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Linux x64 5.15.0-117-generic

I'm using a Docker devcontainer if that makes any difference. Also had the same issue with VSCode 1.85.1

Downgrading to 2.0.9 solves the issue

@musteresel
Copy link

musteresel commented Sep 16, 2024

https://github.com/actboy168/lua-debug/compare/9e1f465..4412c81#diff-3cf49c5cb77b73d73f43a5a0fa4da72179071c9100c3044ef2a3a84bc3a5b58aR105

This snippet from the comparison between 2.0.9 and 2.0.10 looks strange to me. Commit is here 2a353aa but doesn't give much information which bug and why?

Original code filtered events to EPOLLIN or EPOLLOUT when event EPOLLERR or EPOLLHUP comes. New code just adds those events (both; even if they're not there) -- no idea why, but this could be legit: https://stackoverflow.com/a/29206631/1116364

@district10
Copy link

2.0.9 does not work for me either.

@musteresel
Copy link

@actboy168 Is this commit a6a380e referring to this bug here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants