Enable frozen_string_literals

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 gemspec
 

Gemfile.lock

@@ -100,7 +100,9 @@ GEM
     mime-types (3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2016.0521)
-    mimemagic (0.3.3)
+    mimemagic (0.3.10)
+      nokogiri (~> 1)
+      rake
     mini_mime (1.0.1)
     mini_portile2 (2.5.0)
     minitest (5.11.3)
@@ -193,4 +195,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   2.1.4
+   2.2.22

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $:.unshift File.expand_path('../lib', __FILE__)
 require 'offsite_payments/version'
 

bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "offsite_payments"

generators/integration_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "thor/group"
 
 class IntegrationGenerator < Thor::Group

lib/offsite_payments.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 fail %q{
   Money is required for offsite_payments to work, please refer to https://github.com/activemerchant/offsite_payments#money-gem-dependency
 } unless defined?(Money)

lib/offsite_payments/action_view_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'action_pack'
 
 module OffsitePayments #:nodoc:
@@ -63,7 +65,7 @@ def payment_service_for(order, account, options = {}, &proc)
       end
 
       result << '</form>'
-      result= result.join("\n")
+      result = result.join("\n")
 
       concat(result.respond_to?(:html_safe) ? result.html_safe : result)
       nil

lib/offsite_payments/helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module MoneyCompatibility
     def to_cents(money)

lib/offsite_payments/integrations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments
   module Integrations
     Dir[File.dirname(__FILE__) + '/integrations/*.rb'].each do |f|

lib/offsite_payments/integrations/a1agregator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module A1agregator

lib/offsite_payments/integrations/authorize_net_sim.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module AuthorizeNetSim

lib/offsite_payments/integrations/bit_pay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module BitPay

lib/offsite_payments/integrations/bogus.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Bogus

lib/offsite_payments/integrations/checkout_finland.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module CheckoutFinland

lib/offsite_payments/integrations/chronopay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Chronopay

lib/offsite_payments/integrations/citrus.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments
   module Integrations
     module Citrus

lib/offsite_payments/integrations/coinbase.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Coinbase

lib/offsite_payments/integrations/direc_pay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module DirecPay

lib/offsite_payments/integrations/directebanking.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Directebanking

lib/offsite_payments/integrations/doku.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Doku

lib/offsite_payments/integrations/dotpay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Dotpay

lib/offsite_payments/integrations/dwolla.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Dwolla

lib/offsite_payments/integrations/e_payment_plans.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module EPaymentPlans

lib/offsite_payments/integrations/easy_pay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     # Documentation: https://ssl.easypay.by/light/

lib/offsite_payments/integrations/epay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Epay

lib/offsite_payments/integrations/first_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module FirstData

lib/offsite_payments/integrations/gestpay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # With help from Giovanni Intini and his code for RGestPay - http://medlar.it/it/progetti/rgestpay
 
 module OffsitePayments #:nodoc:

lib/offsite_payments/integrations/hi_trust.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module HiTrust

lib/offsite_payments/integrations/ipay88.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Ipay88

lib/offsite_payments/integrations/klarna.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Klarna
@@ -17,12 +19,9 @@ def self.return(query_string, options = {})
       def self.cart_items_payload(fields, cart_items)
         check_required_fields!(fields)
 
-        payload = ""
-        REQUIRED_FIELDS.sort.each do |field|
-           payload << fields[field].to_s
-        end
-
-        payload
+        REQUIRED_FIELDS.sort.map do |field|
+           fields[field].to_s
+        end.join
       end
 
       def self.sign(fields, cart_items, shared_secret)

lib/offsite_payments/integrations/liqpay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     # Documentation: https://www.liqpay.com/?do=pages&p=cnb10

lib/offsite_payments/integrations/maksuturva.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     # USAGE:

lib/offsite_payments/integrations/mollie.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Mollie

lib/offsite_payments/integrations/mollie_ideal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module MollieIdeal

lib/offsite_payments/integrations/mollie_mistercash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module MollieMistercash

lib/offsite_payments/integrations/molpay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Molpay

lib/offsite_payments/integrations/moneybookers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Moneybookers

lib/offsite_payments/integrations/nochex.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     # To start with Nochex, follow the instructions for installing

lib/offsite_payments/integrations/pag_seguro.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
@@ -117,10 +117,10 @@ def fetch_token
 
         def area_code_and_number(phone)
           return if phone.nil?
-          phone.gsub!(/[^\d]/, '')
+          clean_phone = phone.gsub(/[^\d]/, '')
 
-          ddd    = phone.slice(0..1)
-          number = phone.slice(2..12)
+          ddd    = clean_phone.slice(0..1)
+          number = clean_phone.slice(2..12)
 
           [ddd, number]
         end

lib/offsite_payments/integrations/paxum.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     # Documentation:
@@ -89,8 +91,7 @@ class Notification < OffsitePayments::Notification
 
         def initialize(post, options = {})
           @raw_post = post.dup
-          post.slice!(0)
-          super
+          super(post.slice(1..-1), options)
         end
 
         def self.recognizes?(params)

lib/offsite_payments/integrations/pay_fast.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     # Documentation:

lib/offsite_payments/integrations/paydollar.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Paydollar

lib/offsite_payments/integrations/payflow_link.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module PayflowLink

lib/offsite_payments/integrations/paypal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Paypal
@@ -93,10 +95,8 @@ def shipping_address(params = {})
           add_field(mappings[:shipping_address][:country], country_code)
 
           if params.has_key?(:phone)
-            phone = params.delete(:phone).to_s
-
             # Wipe all non digits
-            phone.gsub!(/\D+/, '')
+            phone = params.delete(:phone).to_s.gsub(/\D+/, '')
 
             if ['US', 'CA'].include?(country_code) && phone =~ /(\d{3})(\d{3})(\d{4})$/
               add_field('night_phone_a', $1)

lib/offsite_payments/integrations/paypal_payments_advanced.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments
   module Integrations
     module PaypalPaymentsAdvanced

lib/offsite_payments/integrations/paysbuy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Paysbuy

lib/offsite_payments/integrations/paytm.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Paytm

lib/offsite_payments/integrations/payu_in.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module PayuIn

lib/offsite_payments/integrations/payu_in_paisa.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments
   module Integrations
     module PayuInPaisa

lib/offsite_payments/integrations/platron.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'builder'
 
 module OffsitePayments #:nodoc:
@@ -137,7 +139,7 @@ def acknowledge(authcode = nil)
 
         def success_response(path,secret)
           salt = rand(36**15).to_s(36)
-          xml = ""
+          xml = +""
           doc = Builder::XmlMarkup.new(:target => xml)
           sign = Platron.generate_signature({:pg_status => 'ok', :pg_salt => salt}, path, secret)
           doc.response do

lib/offsite_payments/integrations/pxpay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rexml/document'
 
 module OffsitePayments #:nodoc:

lib/offsite_payments/integrations/quickpay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Quickpay

lib/offsite_payments/integrations/quickpay_v10.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'openssl'
 
 module OffsitePayments #:nodoc: